Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[14.1.X] Remove legacy L1T digis dependencies in Online DQM #46731

Merged

Conversation

mmusich
Copy link
Contributor

@mmusich mmusich commented Nov 19, 2024

backport of #46716

PR description:

In the ticket CMSALCAFAST-94, while testing a new Global Tag candidate meant for a general cleaning of unused / previous runs unmaintained records, few online DQM clients (dt4ml, dt, ecal, and hlt) encountered issues and failed.
The reason of these failures was analyzed as unnecessary dependencies of the current DQM clients on the legacy L1T digis.
This is fixed / worked around in this PR.

  • 759b8ca removes the dependency in HLTSiStripMonitorCluster by means of re-configuring the few instances of GenericTriggerEventFlag class to use the stage 2 gt digis in presence of the stage2L1Trigger modifier.
  • 6e2e276 replaces the legacy gt digis with the stage2 ones in presence of the stage2L1Trigger modifier
  • 1e37edb works around the fact that the DQM/EcalMonitorTasks/src/ClusterTask.cc natively doesn't support the stage2 L1T setup but requires products from the legacy L1T (this is followed up also at ClusterTask (in DQM/EcalMonitorTasks) depends on legacy L1T Global Trigger information #46715)

PR validation:

The following commands work with this branch,

scram b runtests_TestDQMOnlineClient-hlt_dqm_sourceclient use-ibeos
scram b runtests_TestDQMOnlineClient-dt_dqm_sourceclient use-ibeos
scram b runtests_TestDQMOnlineClient-dt4ml_dqm_sourceclient use-ibeos
scram b runtests_TestDQMOnlineClient-ecal_dqm_sourceclient use-ibeos

when tested by using the Global Tag proposed at CMSALCAFAST-94.

diff --git a/DQM/Integration/python/config/FrontierCondition_GT_cfi.py b/DQM/Integration/python/config/FrontierCondition_GT_cfi.py
index 5845afa34bb..a91ce205422 100644
--- a/DQM/Integration/python/config/FrontierCondition_GT_cfi.py
+++ b/DQM/Integration/python/config/FrontierCondition_GT_cfi.py
@@ -1,7 +1,7 @@
 import FWCore.ParameterSet.Config as cms
 from Configuration.StandardSequences.FrontierConditions_GlobalTag_cff import *
 from Configuration.AlCa.autoCond import autoCond
-GlobalTag.globaltag = autoCond['run3_hlt']
+GlobalTag.globaltag = "141X_dataRun3_HLT_Candidate_2024_11_15_CleaningOfRecords"  #autoCond['run3_hlt']
 
 #############################################
 #

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

Verbatim backport of #46716 to the last 2024 data-taking release.

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 19, 2024

A new Pull Request was created by @mmusich for CMSSW_14_1_X.

It involves the following packages:

  • DQM/DTMonitorModule (dqm)
  • DQM/EcalMonitorTasks (dqm)
  • DQM/Integration (dqm)
  • DQMOffline/Trigger (dqm)

@antoniovagnerini, @cmsbuild, @rseidita can you please review it and eventually sign? Thanks.
@Fedespring, @HuguesBrun, @ReyerBand, @argiro, @batinkov, @battibass, @cericeci, @francescobrivio, @jhgoh, @missirol, @mtosi, @rchatter, @rociovilar, @thomreis, @threus, @trocino, @wang0jin this is something you requested to watch as well.
@antoniovilela, @mandrenguyen, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 19, 2024

cms-bot internal usage

@mmusich
Copy link
Contributor Author

mmusich commented Nov 19, 2024

@cmsbuild, please test

@cmsbuild
Copy link
Contributor

+1

Size: This PR adds an extra 28KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-1a960d/42942/summary.html
COMMIT: 1e37edb
CMSSW: CMSSW_14_1_X_2024-11-18-2300/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/46731/42942/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially added 3 lines to the logs
  • Reco comparison results: 8 differences found in the comparisons
  • DQMHistoTests: Total files compared: 46
  • DQMHistoTests: Total histograms compared: 3565669
  • DQMHistoTests: Total failures: 2
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3565647
  • DQMHistoTests: Total skipped: 20
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 45 files compared)
  • Checked 199 log files, 169 edm output root files, 46 DQM output files
  • TriggerResults: no differences found

@antoniovagnerini
Copy link

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_14_1_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_14_2_X is complete. This pull request will now be reviewed by the release team before it's merged. @rappoccio, @sextonkennedy, @antoniovilela, @mandrenguyen (and backports should be raised in the release meeting by the corresponding L2)

@mmusich
Copy link
Contributor Author

mmusich commented Nov 25, 2024

@cms-sw/orp-l2 what's preventing merge here?

@mandrenguyen
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit a68603d into cms-sw:CMSSW_14_1_X Nov 26, 2024
9 checks passed
@mmusich mmusich deleted the mm_dev_fix_L1Tstage1Dependencies_14_1_X branch December 13, 2024 09:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants