-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[14.1.X] Remove legacy L1T digis dependencies in Online DQM #46731
[14.1.X] Remove legacy L1T digis dependencies in Online DQM #46731
Conversation
A new Pull Request was created by @mmusich for CMSSW_14_1_X. It involves the following packages:
@antoniovagnerini, @cmsbuild, @rseidita can you please review it and eventually sign? Thanks. cms-bot commands are listed here
|
cms-bot internal usage |
@cmsbuild, please test |
+1 Size: This PR adds an extra 28KB to repository Comparison SummarySummary:
|
+1 |
This pull request is fully signed and it will be integrated in one of the next CMSSW_14_1_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_14_2_X is complete. This pull request will now be reviewed by the release team before it's merged. @rappoccio, @sextonkennedy, @antoniovilela, @mandrenguyen (and backports should be raised in the release meeting by the corresponding L2) |
@cms-sw/orp-l2 what's preventing merge here? |
+1 |
backport of #46716
PR description:
In the ticket CMSALCAFAST-94, while testing a new Global Tag candidate meant for a general cleaning of unused / previous runs unmaintained records, few online DQM clients (
dt4ml
,dt
,ecal
, andhlt
) encountered issues and failed.The reason of these failures was analyzed as unnecessary dependencies of the current DQM clients on the legacy L1T digis.
This is fixed / worked around in this PR.
HLTSiStripMonitorCluster
by means of re-configuring the few instances ofGenericTriggerEventFlag
class to use the stage 2 gt digis in presence of thestage2L1Trigger
modifier.stage2L1Trigger
modifierDQM/EcalMonitorTasks/src/ClusterTask.cc
natively doesn't support the stage2 L1T setup but requires products from the legacy L1T (this is followed up also atClusterTask
(inDQM/EcalMonitorTasks
) depends on legacy L1T Global Trigger information #46715)PR validation:
The following commands work with this branch,
when tested by using the Global Tag proposed at CMSALCAFAST-94.
If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:
Verbatim backport of #46716 to the last 2024 data-taking release.