(HLT) fix service discovery in HLTriggerJSONMonitoring

[smorovic]

PR description:

Service template type should not be a pointer. This caused FastMonitoringService service to not be detected and caused output not being suppressed when exception is thrown in HLT.

PR validation:

Modification was tested on replayed error stream data from 2024 HI run and fixes the problem.

[cmsbuild]

cms-bot internal usage

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-46760/42742

[smorovic]

@cmsbuild please test

[cmsbuild]

A new Pull Request was created by @smorovic for master.

It involves the following packages:

• HLTrigger/JSONMonitoring (hlt)

@Martin-Grunewald, @mmusich can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @fwyzard, @missirol, @mmusich, @silviodonato this is something you requested to watch as well.
@antoniovilela, @mandrenguyen, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-46760/42743

[cmsbuild]

Pull request #46760 was updated. @Martin-Grunewald, @cmsbuild, @mmusich can you please check and sign again.

[smorovic]

Actually we can also simplify more and drop writeFiles.

[cmsbuild]

Milestone for this pull request has been moved to CMSSW_15_0_X. Please open a backport if it should also go in to CMSSW_14_2_X.

[mmusich]

@cmsbuild, please test

[cmsbuild]

+1

Size: This PR adds an extra 24KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-a0ff1f/43010/summary.html
COMMIT: 8f13c7a
CMSSW: CMSSW_14_2_X_2024-11-21-2300/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/46760/43010/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• You potentially removed 2 lines from the logs
• Reco comparison results: 11 differences found in the comparisons
• DQMHistoTests: Total files compared: 46
• DQMHistoTests: Total histograms compared: 3483722
• DQMHistoTests: Total failures: 469
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3483233
• DQMHistoTests: Total skipped: 20
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 45 files compared)
• Checked 202 log files, 172 edm output root files, 46 DQM output files
• TriggerResults: no differences found

[mmusich]

+hlt

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @rappoccio, @antoniovilela, @sextonkennedy, @mandrenguyen (and backports should be raised in the release meeting by the corresponding L2)

[mandrenguyen]

+1