Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix off by 1 error in Multi5x5ClusterAlgo #46787

Merged
merged 1 commit into from
Nov 25, 2024

Conversation

Dr15Jones
Copy link
Contributor

PR description:

This fixes an off by one error introduced in #46756

PR validation:

Added printout of Clusters in the changed module both before and after #46756 and found differences with hits in cluster. With this change the printouts now match the results of before the PR.

@Dr15Jones
Copy link
Contributor Author

please test

@Dr15Jones
Copy link
Contributor Author

@makortel FYI

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 23, 2024

cms-bot internal usage

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @Dr15Jones for master.

It involves the following packages:

  • RecoEcal/EgammaClusterAlgos (reconstruction)

@jfernan2, @mandrenguyen can you please review it and eventually sign? Thanks.
@Prasant1993, @ReyerBand, @Sam-Harper, @a-kapoor, @afiqaize, @argiro, @jainshilpi, @lgray, @missirol, @ram1123, @rchatter, @sameasy, @sobhatta, @thomreis, @valsdav, @varuns23, @wang0jin this is something you requested to watch as well.
@antoniovilela, @mandrenguyen, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

+1

Size: This PR adds an extra 20KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-fef795/43026/summary.html
COMMIT: c930ed1
CMSSW: CMSSW_15_0_X_2024-11-23-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/46787/43026/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

@Dr15Jones
Copy link
Contributor Author

differences are expected

@Dr15Jones
Copy link
Contributor Author

type bugfix

@jfernan2
Copy link
Contributor

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @sextonkennedy, @rappoccio, @mandrenguyen, @antoniovilela (and backports should be raised in the release meeting by the corresponding L2)

@makortel
Copy link
Contributor

Since #46756 was merged in 14_2_X (just before branching off 15_0_X or something), this PR needs to be backported to 14_2_X.

@mandrenguyen
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 5295006 into cms-sw:master Nov 25, 2024
19 of 20 checks passed
@Dr15Jones Dr15Jones deleted the fixMulti5x5ClusterAlgo branch November 26, 2024 16:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants