-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix off by 1 error in Multi5x5ClusterAlgo #46787
Conversation
please test |
@makortel FYI |
cms-bot internal usage |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-46787/42770 |
A new Pull Request was created by @Dr15Jones for master. It involves the following packages:
@jfernan2, @mandrenguyen can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
+1 Size: This PR adds an extra 20KB to repository Comparison SummarySummary:
|
differences are expected |
type bugfix |
+1 |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @sextonkennedy, @rappoccio, @mandrenguyen, @antoniovilela (and backports should be raised in the release meeting by the corresponding L2) |
Since #46756 was merged in 14_2_X (just before branching off 15_0_X or something), this PR needs to be backported to 14_2_X. |
+1 |
PR description:
This fixes an off by one error introduced in #46756
PR validation:
Added printout of Clusters in the changed module both before and after #46756 and found differences with hits in cluster. With this change the printouts now match the results of before the PR.