Improve messages due `VertexException` in `SequentialPrimaryVertexFitterAdapter` and clean-up of `BeamSpotOnlineProducer` #46893

mmusich · 2024-12-07T10:46:10Z

PR description:

This is a follow-up to #45555 (comment).

a4a0d16 annotates SequentialPrimaryVertexFitterAdapter::fit exceptions of the VertexExcpetion type according to the suggestions at HLT crash in run 383631 - 'VertexException' and HcalDigisProducerGPU:hltHcalDigisGPU error #45555 (comment)
a390d6b contains a generalized clean-up / refactoring of BeamSpotOnlineProducer in order to be more modular (and hopefully more easily debuggable).

PR validation:

cmssw compiles. Run an HLT job in normal conditions and didn't observe anomalies.
Inducing the type of VertexException that is being caught now, I get the following type of log messages:

%MSG-e UnusableBeamSpot:  PrimaryVertexProducer:hltVerticesPF  07-Dec-2024 11:13:50 CET Run: 386614 Event: 48610345
Beamspot with invalid errors [            0           0           0
             0           0           0
             0           0           0 ]
%MSG
----- Begin Fatal Exception 07-Dec-2024 11:13:50 CET-----------------------
An exception of category 'VertexException' occurred while
   [0] Processing  Event run: 386614 lumi: 55 event: 48610345 stream: 0
   [1] Running path 'MC_AK8PFJetPNet_v4'
   [2] Calling method for module PrimaryVertexProducer/'hltVerticesPF'
   [3] While processing SequentialPrimaryVertexFitterAdapter::fit() with BeamSpot parameters: 
-----------------------------------------------------
              Beam Spot Data

 Beam type    = -1
       X0     = 0 +/- 0 [cm]
       Y0     = 0 +/- 0 [cm]
       Z0     = 0 +/- 0 [cm]
 Sigma Z0     = 0 +/- 0 [cm]
 dxdz         = 0 +/- 0 [radians]
 dydz         = 0 +/- 0 [radians]
 Beam width X = 0 +/- 0 [cm]
 Beam width Y = 0 +/- 0 [cm]
 EmittanceX   = 0 [cm]
 EmittanceY   = 0 [cm]
 beta-star    = 0 [cm]
-----------------------------------------------------


Exception Message:
BasicSingleVertexState::could not invert error matrix

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

N/A

cmsbuild · 2024-12-07T10:46:29Z

cms-bot internal usage

cmsbuild · 2024-12-07T10:49:12Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-46893/42938

cmsbuild · 2024-12-07T10:49:37Z

A new Pull Request was created by @mmusich for master.

It involves the following packages:

RecoVertex/BeamSpotProducer (reconstruction, alca)
RecoVertex/PrimaryVertexProducer (reconstruction)

@atpathak, @cmsbuild, @consuegs, @jfernan2, @mandrenguyen, @perrotta can you please review it and eventually sign? Thanks.
@GiacomoSguazzoni, @VinInn, @VourMa, @dgulhan, @fabiocos, @francescobrivio, @martinamalberti, @missirol, @mmusich, @mtosi, @rovere, @rsreds, @tocheng, @yuanchao this is something you requested to watch as well.
@antoniovilela, @mandrenguyen, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

perrotta · 2024-12-08T09:59:11Z

RecoVertex/BeamSpotProducer/plugins/BeamSpotOnlineProducer.cc

-    reco::BeamSpot::Point apoint(spotDB->x(), spotDB->y(), spotDB->z());
+  double sigmaZ = (theSetSigmaZ > 0) ? theSetSigmaZ : spotDB.sigmaZ();
+  result = reco::BeamSpot(apoint, sigmaZ, spotDB.dxdz(), spotDB.dydz(), spotDB.beamWidthX(), matrix);
+  result.setBeamWidthY(spotDB.beamWidthY());


Not related to this PR (if not because of the part of the original code which is touched by it), but why not also setBeamWidthX?

but why not also setBeamWidthX

the x-width is already set in the constructor at L162:

result = reco::BeamSpot(apoint, sigmaZ, spotDB.dxdz(), spotDB.dydz(), spotDB.beamWidthX(), matrix);

as per method signature:

cmssw/DataFormats/BeamSpot/interface/BeamSpot.h

Lines 39 to 45 in e9b58be

BeamSpot(const Point& point,

double sigmaZ,

double dxdz,

double dydz,

double BeamWidthX,

const CovarianceMatrix& error,

BeamType type = Unknown) {

as both widths are constructed with the same value (in the hypothesis of round-optics)

cmssw/DataFormats/BeamSpot/interface/BeamSpot.h

Lines 50 to 51 in e9b58be

BeamWidthX_ = BeamWidthX;

BeamWidthY_ = BeamWidthX;

setting explicitly the y component is necessary if the two differ (and in principle they will differ in 2025, if the flat optics is used).

setting explicitly the y component is necessary if the two differ (and in principle they will differ in 2025, if the flat optics is used).

Ah, ok: that was indeed my worry. Thank you for confirming that the two directions can be set independently,

perrotta · 2024-12-08T10:03:20Z

please test

cmsbuild · 2024-12-08T11:51:38Z

+1

Size: This PR adds an extra 12KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-c3bfb0/43315/summary.html
COMMIT: a390d6b
CMSSW: CMSSW_15_0_X_2024-12-08-0000/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/46893/43315/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

You potentially added 1 lines to the logs
Reco comparison results: 284 differences found in the comparisons
DQMHistoTests: Total files compared: 47
DQMHistoTests: Total histograms compared: 3623082
DQMHistoTests: Total failures: 2443
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 3620619
DQMHistoTests: Total skipped: 20
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 46 files compared)
Checked 206 log files, 177 edm output root files, 47 DQM output files
TriggerResults: found differences in 1 / 45 workflows

jfernan2 · 2024-12-09T11:56:09Z

+1

perrotta · 2024-12-09T13:53:54Z

+alca

cmsbuild · 2024-12-09T13:54:18Z

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @sextonkennedy, @rappoccio, @antoniovilela, @mandrenguyen (and backports should be raised in the release meeting by the corresponding L2)

mandrenguyen · 2024-12-09T17:45:43Z

+1

mmusich added 2 commits December 7, 2024 11:17

annotate SequentialPrimaryVertexFitterAdapter::fit exception

a4a0d16

re-organize BeamSpotOnlineProducer to be more modular

a390d6b

cmsbuild added this to the CMSSW_15_0_X milestone Dec 7, 2024

cmsbuild added reconstruction-pending alca-pending pending-signatures tests-pending orp-pending code-checks-pending tracking labels Dec 7, 2024

mmusich mentioned this pull request Dec 7, 2024

HLT crash in run 383631 - 'VertexException' and HcalDigisProducerGPU:hltHcalDigisGPU error #45555

Open

cmsbuild added code-checks-approved and removed code-checks-pending labels Dec 7, 2024

perrotta reviewed Dec 8, 2024

View reviewed changes

cmsbuild added tests-started and removed tests-pending labels Dec 8, 2024

cmsbuild added tests-approved and removed tests-started labels Dec 8, 2024

cmsbuild added reconstruction-approved and removed reconstruction-pending labels Dec 9, 2024

cmsbuild added alca-approved and removed alca-pending pending-signatures labels Dec 9, 2024

cmsbuild added the fully-signed label Dec 9, 2024

cmsbuild added orp-approved and removed orp-pending labels Dec 9, 2024

cmsbuild merged commit b1d0e43 into cms-sw:master Dec 9, 2024
11 checks passed

mmusich deleted the mm_improve_HLT_beamspot_45555 branch December 9, 2024 17:51

cmsbuild mentioned this pull request Dec 10, 2024

[DEVEL] Use correct objs for bin/test cms-sw/cmsdist#9562

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Improve messages due `VertexException` in `SequentialPrimaryVertexFitterAdapter` and clean-up of `BeamSpotOnlineProducer` #46893

Improve messages due `VertexException` in `SequentialPrimaryVertexFitterAdapter` and clean-up of `BeamSpotOnlineProducer` #46893

mmusich commented Dec 7, 2024

cmsbuild commented Dec 7, 2024 •

edited

Loading

cmsbuild commented Dec 7, 2024

cmsbuild commented Dec 7, 2024

perrotta Dec 8, 2024

mmusich Dec 8, 2024

perrotta Dec 9, 2024

perrotta commented Dec 8, 2024

cmsbuild commented Dec 8, 2024

jfernan2 commented Dec 9, 2024

perrotta commented Dec 9, 2024

cmsbuild commented Dec 9, 2024

mandrenguyen commented Dec 9, 2024

	BeamSpot(const Point& point,
	double sigmaZ,
	double dxdz,
	double dydz,
	double BeamWidthX,
	const CovarianceMatrix& error,
	BeamType type = Unknown) {

Improve messages due VertexException in SequentialPrimaryVertexFitterAdapter and clean-up of BeamSpotOnlineProducer #46893

Improve messages due VertexException in SequentialPrimaryVertexFitterAdapter and clean-up of BeamSpotOnlineProducer #46893

Conversation

mmusich commented Dec 7, 2024

PR description:

PR validation:

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

cmsbuild commented Dec 7, 2024 • edited Loading

cmsbuild commented Dec 7, 2024

cmsbuild commented Dec 7, 2024

perrotta Dec 8, 2024

Choose a reason for hiding this comment

mmusich Dec 8, 2024

Choose a reason for hiding this comment

perrotta Dec 9, 2024

Choose a reason for hiding this comment

perrotta commented Dec 8, 2024

cmsbuild commented Dec 8, 2024

Comparison Summary

jfernan2 commented Dec 9, 2024

perrotta commented Dec 9, 2024

cmsbuild commented Dec 9, 2024

mandrenguyen commented Dec 9, 2024

Improve messages due `VertexException` in `SequentialPrimaryVertexFitterAdapter` and clean-up of `BeamSpotOnlineProducer` #46893

Improve messages due `VertexException` in `SequentialPrimaryVertexFitterAdapter` and clean-up of `BeamSpotOnlineProducer` #46893

cmsbuild commented Dec 7, 2024 •

edited

Loading