Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Addition of RelVal to HLT HG Combined PCL workflow #46956

Merged
merged 2 commits into from
Dec 17, 2024

Conversation

phnattla
Copy link
Contributor

PR description:

This PR implements a RelVal to PR #46888, which introduced a new High Granularity Tracker Alignment Prompt Calibration Loop using both MinumumBias and Z → µµ data ("HG Combined alignment"), aiming to provide alignment conditions for the High Level Triggers (HLT).
The new RelVal has the id 1002.5.

PR validation:

The following command was successfully used to validate:

runTheMatrix.py -l 1002.5 --ibeos

Cc: @mmusich @henriettepetersen @TomasKello

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 16, 2024

cms-bot internal usage

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-46956/43022

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @phnattla for master.

It involves the following packages:

  • Configuration/PyReleaseValidation (pdmv, upgrade)

@AdrianoDee, @Moanwar, @cmsbuild, @DickyChant, @miquork, @srimanob, @subirsarkar can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @fabiocos, @makortel, @missirol, @slomeo this is something you requested to watch as well.
@antoniovilela, @mandrenguyen, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

@mmusich
Copy link
Contributor

mmusich commented Dec 16, 2024

test parameters:

  • workflow = 1002.5

@mmusich
Copy link
Contributor

mmusich commented Dec 16, 2024

@cmsbuild, please test

@cmsbuild
Copy link
Contributor

+1

Size: This PR adds an extra 64KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-4812d9/43467/summary.html
COMMIT: e64390f
CMSSW: CMSSW_15_0_X_2024-12-15-2300/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/46956/43467/install.sh to create a dev area with all the needed externals and cmssw changes.

  • DAS Queries: The DAS query tests failed, see the summary page for details.

Comparison Summary

Summary:

  • You potentially removed 2 lines from the logs
  • Reco comparison results: 4 differences found in the comparisons
  • DQMHistoTests: Total files compared: 46
  • DQMHistoTests: Total histograms compared: 3510017
  • DQMHistoTests: Total failures: 419
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3509578
  • DQMHistoTests: Total skipped: 20
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 45 files compared)
  • Checked 202 log files, 172 edm output root files, 46 DQM output files
  • TriggerResults: found differences in 1 / 44 workflows

@mmusich
Copy link
Contributor

mmusich commented Dec 16, 2024

@perrotta FYI

@AdrianoDee
Copy link
Contributor

+pdmv

@Moanwar
Copy link
Contributor

Moanwar commented Dec 17, 2024

+Upgrade

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @antoniovilela, @rappoccio, @mandrenguyen, @sextonkennedy (and backports should be raised in the release meeting by the corresponding L2)

@mandrenguyen
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 642618b into cms-sw:master Dec 17, 2024
12 checks passed
@mmusich mmusich deleted the HLT_HGComb_relval_test branch January 6, 2025 12:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants