-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Backport of #6030. Add features offline validation for71 x #6072
Backport of #6030. Add features offline validation for71 x #6072
Conversation
A new Pull Request was created by @tlampen (Tapio Lampén) for CMSSW_7_1_X. Backport of #6030. Add features offline validation for71 x It involves the following packages: Alignment/OfflineValidation @diguida, @cerminar, @cmsbuild, @nclopezo, @rcastello, @mmusich can you please review it and eventually sign? Thanks. |
-1 runTheMatrix-results/4.53_RunPhoton2012B+RunPhoton2012B+HLTD+RECODreHLT+HARVESTDreHLT/step2_RunPhoton2012B+RunPhoton2012B+HLTD+RECODreHLT+HARVESTDreHLT.log you can see the results of the tests here: |
+1 |
This pull request is fully signed and it will be integrated in one of the next CMSSW_7_1_X IBs unless changes (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @ktf, @smuzaffar |
I don't think this is needed in 71x. Is there any reason? |
@davidlange6 : If you can guarantee that there will never be a need or request to run alignment on any data/MC on 71x, then I agree. If you cannot give this guarantee, please merge in. |
Given the lack of such data I guess we can wait and expend effort when such data exists. On Jan 24, 2015, at 11:19 AM, Frank Meier <[email protected]mailto:[email protected]> wrote: @davidlange6https://github.com/davidlange6 : If you can guarantee that there will never be a need or request to run alignment on any data/MC on 71x, then I agree. If you cannot give this guarantee, please merge in. — |
@davidlange6 Such data indeed exists: |
+1 |
…_for71X Backport of #6030. Add features offline validation for71 x
In offline validation: two bugfixes and lots of improvements to automatize
plotting.