Add ObjectSelectorStreamProducer template and use it for RecoTrackViewRefSelector #9904
Conversation
These EDProducer-variants are intended for cases where the event filtering functionality will not be needed.
|
A new Pull Request was created by @makortel (Matti Kortelainen) for CMSSW_7_6_X. Add ObjectSelectorStreamProducer template and use it for RecoTrackViewRefSelector It involves the following packages: CommonTools/RecoAlgos @cvuosalo, @monttj, @cmsbuild, @deguio, @slava77, @vadler, @danduggan can you please review it and eventually sign? Thanks. |
|
@cmsbuild please test |
|
The tests are being triggered in jenkins. |
| */ | ||
| template<typename Selector, | ||
| typename OutputCollection = typename ::helper::SelectedOutputCollectionTrait<typename Selector::collection>::type, | ||
| typename PostProcessor = ::helper::NullPostProcessor<OutputCollection, edm::EDProducer>, |
There was a problem hiding this comment.
Do we even want to leave a default edm::EDProducer here?
Can this be just "typename blah" ?
There was a problem hiding this comment.
I don't disagree on dropping edm::EDProcucer. I'll then remove this header and make ObjectSelectorStreamProducer the main template definition.
There was a problem hiding this comment.
in case edm::one or global instances of this template will be needed, maybe we should keep the generic definition.
I just didn't want to have the edm::EDProducer to be the default argument in the template args
There was a problem hiding this comment.
Right, taking out the default values for the template parameters of ObjectSelectorProducer (as the stream/global/one-ones would anyway have to give them explicitly) could be the most clear option.
Even with stream being the default, the one/global cases could still be instantiated from it (the only "penalty" wrt. current situation would be the inclusion of ".../stream/EDProducer.h" header where it is not strictly needed).
Anyway, I'll do an update with default values for template parameters of ObjectSelectorProducer removed.
|
This pull request is fully signed and it will be integrated in one of the next CMSSW_7_6_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar |
|
+1 |
Add ObjectSelectorStreamProducer template and use it for RecoTrackViewRefSelector
Here is an attempt to address @Dr15Jones' comment (#9201 (comment)) about ignored EDFilters (in tracking validation sequence). Basically the PR adds new
ObjectSelector(Stream)Producertemplates similar to currentObjectSelector(Stream)but being EDProducers (I'm not sure if the legacy-default is still "needed", I decided to include it only to have similar code structure asObjectSelector(Stream)).As a use case I added RecoTrackViewRefSelector (existing RecoTrack(Ref)Selectors take
vector<Track>as an input, and I'll soon need anyway a version reading the input viaView), and switched the tracking MC validation sequence to use it.Tested in CMSSW_7_6_X_2015-06-24-2300, no changes expected in results.
@rovere @VinInn