Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow compiler package to have deps #199

Merged
merged 2 commits into from
Nov 20, 2023
Merged

Allow compiler package to have deps #199

merged 2 commits into from
Nov 20, 2023

Conversation

smuzaffar
Copy link
Contributor

No description provided.

@smuzaffar smuzaffar mentioned this pull request Nov 16, 2023
Closed
@cmsbuild
Copy link
Contributor

A new Pull Request was created by @smuzaffar (Malik Shahzad Muzaffar) for branch V00-34-XX.

@aandvalenzuela, @smuzaffar, @iarspider, @cmsbuild can you please review it and eventually sign? Thanks.
@rappoccio, @sextonkennedy, @antoniovilela you are the release manager for this.
cms-bot commands are listed here

@smuzaffar
Copy link
Contributor Author

please test with cms-sw/cmsdist#8823

@smuzaffar smuzaffar mentioned this pull request Nov 16, 2023
Open
@smuzaffar
Copy link
Contributor Author

please test with cms-sw/cmsdist#8388

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-91cc39/35888/summary.html
COMMIT: 9faa81d
CMSSW: CMSSW_14_0_X_2023-11-16-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/pkgtools/199/35888/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially added 2 lines to the logs
  • Reco comparison results: 22 differences found in the comparisons
  • DQMHistoTests: Total files compared: 50
  • DQMHistoTests: Total histograms compared: 3363070
  • DQMHistoTests: Total failures: 1436
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3361612
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 49 files compared)
  • Checked 214 log files, 167 edm output root files, 50 DQM output files
  • TriggerResults: no differences found

@smuzaffar
Copy link
Contributor Author

please test with cms-sw/cmsdist#8823

@cmsbuild
Copy link
Contributor

-1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-91cc39/35907/summary.html
COMMIT: 9faa81d
CMSSW: CMSSW_14_0_X_2023-11-16-2300/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/pkgtools/199/35907/install.sh to create a dev area with all the needed externals and cmssw changes.

External Build

I found compilation warning when building: See details on the summary page.

@smuzaffar
Copy link
Contributor Author

please test with cms-sw/cmsdist#8823

@cmsbuild
Copy link
Contributor

-1

Failed Tests: UnitTests RelVals
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-91cc39/35910/summary.html
COMMIT: 9faa81d
CMSSW: CMSSW_14_0_X_2023-11-16-2300/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/pkgtools/199/35910/install.sh to create a dev area with all the needed externals and cmssw changes.

Unit Tests

I found 3 errors in the following unit tests:

---> test runtestRecoEgammaElectronIdentification had ERRORS
---> test testTauEmbeddingProducers had ERRORS
---> test RecoPPSLocalNewT2 had ERRORS

RelVals

----- Begin Fatal Exception 17-Nov-2023 23:01:59 CET-----------------------
An exception of category 'MVA config failure: ' occurred while
   [0] Constructing the EventProcessor
   [1] Constructing module: class=ElectronMVAValueMapProducer label='electronMVAValueMapProducer'
Exception Message:
Concerning ElectronMVAEstimatorRun2RunIIIWinter22NoIsoV1
Variable ele_hcalPFClusterIso not found in variable definition file!
----- End Fatal Exception -------------------------------------------------

----- Begin Fatal Exception 17-Nov-2023 23:01:59 CET-----------------------
An exception of category 'MVA config failure: ' occurred while
   [0] Constructing the EventProcessor
   [1] Constructing module: class=ElectronMVAValueMapProducer label='electronMVAValueMapProducer'
Exception Message:
Concerning ElectronMVAEstimatorRun2RunIIIWinter22NoIsoV1
Variable ele_hcalPFClusterIso not found in variable definition file!
----- End Fatal Exception -------------------------------------------------

----- Begin Fatal Exception 17-Nov-2023 23:01:59 CET-----------------------
An exception of category 'MVA config failure: ' occurred while
   [0] Constructing the EventProcessor
   [1] Constructing module: class=ElectronMVAValueMapProducer label='electronMVAValueMapProducer'
Exception Message:
Concerning ElectronMVAEstimatorRun2RunIIIWinter22NoIsoV1
Variable ele_hcalPFClusterIso not found in variable definition file!
----- End Fatal Exception -------------------------------------------------
Expand to see more relval errors ...

@smuzaffar
Copy link
Contributor Author

please test with cms-sw/cmsdist#8823

@smuzaffar
Copy link
Contributor Author

please test with cms-sw/cmsdist#8827 for el8_aarch64_gcc12

@cms-sw cms-sw deleted a comment from cmsbuild Nov 19, 2023
@cmsbuild
Copy link
Contributor

Pull request #199 was updated.

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-91cc39/35945/summary.html
COMMIT: d98bcda
CMSSW: CMSSW_14_0_X_2023-11-17-2300/el8_aarch64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/pkgtools/199/35945/install.sh to create a dev area with all the needed externals and cmssw changes.

@cmsbuild
Copy link
Contributor

-1

Failed Tests: UnitTests
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-91cc39/35944/summary.html
COMMIT: d98bcda
CMSSW: CMSSW_14_0_X_2023-11-19-0000/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/pkgtools/199/35944/install.sh to create a dev area with all the needed externals and cmssw changes.

Unit Tests

I found 1 errors in the following unit tests:

---> test RecoPPSLocalNewT2 had ERRORS

Comparison Summary

Summary:

@smuzaffar smuzaffar merged commit c4ddeec into V00-34-XX Nov 20, 2023
@smuzaffar smuzaffar deleted the compiler-deps branch December 2, 2023 14:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
externals-pending orp-pending pending-signatures requires-external tests-rejected
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@smuzaffar @cmsbuild