Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for S3 session keys #108

Merged
merged 2 commits into from
Dec 6, 2015
Merged

Conversation

holzman
Copy link

@holzman holzman commented Dec 2, 2015

This branch fixes a bug in TWebFile (infinite loop when getting an HTTP Error 301), but more importantly adds support for AWS S3 session tokens (https://docs.aws.amazon.com/IAM/latest/UserGuide/id_credentials_temp.html).

These were submitted to vanilla ROOT also under these PRs:
root-project#108 and root-project#110

@cmsbuild
Copy link

cmsbuild commented Dec 2, 2015

A new Pull Request was created by @holzman for branch cms/3836513.

@cmsbuild, @smuzaffar, @Degano, @iahmad-khan, @davidlange6 can you please review it and eventually sign? Thanks.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.

external issue cms-sw/cmsdist#2008

@sextonkennedy
Copy link
Member

@smuzaffar @davidlange6 Chris and I would really like to see this go into a 7_6 release so that we can start testing with it. Can we start the process by putting it in 8_0_X ? Sorry we can't make the ORP today.

Thanks, Liz

@davidlange6
Copy link

I believe the integration tests are ongoing

On Dec 2, 2015, at 4:29 PM, sextonkennedy [email protected] wrote:

@smuzaffar @davidlange6 Chris and I would really like to see this go into a 7_6 release so that we can start testing with it. Can we start the process by putting it in 8_0_X ? Sorry we can't make the ORP today.

Thanks, Liz


Reply to this email directly or view it on GitHub.

@ghost
Copy link

ghost commented Dec 2, 2015

@sextonkennedy @davidlange6 Yes, you can check the progress here: cms-sw/cmsdist#2009 (that's only a dummy PR to check the content of this patch.)

@smuzaffar
Copy link

smuzaffar added a commit that referenced this pull request Dec 6, 2015
@smuzaffar smuzaffar merged commit cedd4a8 into cms-sw:cms/3836513 Dec 6, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants