-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Testing] Delete the object held by gROOT after we reset the globals. #186
Conversation
A new Pull Request was created by @aandvalenzuela (Andrea Valenzuela) for branch cms/master/2a54a16c7c. @cmsbuild, @smuzaffar, @aandvalenzuela, @iarspider can you please review it and eventually sign? Thanks. |
please test for CMSSW_13_3_ROOT6_X |
For example this allows unique_ptr to be deleted first and thus inform TROOT if need be. Fix root-project#13462
Pull request #186 was updated. |
please test for CMSSW_13_3_ROOT6_X |
-1 Failed Tests: UnitTests Unit TestsI found errors in the following unit tests: ---> test Miscellanea had ERRORS ---> test PrimaryVertex had ERRORS ---> test testDataFormatsScoutingRun3 had ERRORS ---> test testDataFormatsScoutingRun2 had ERRORS and more ... Comparison SummarySummary:
|
It seems tests are still failing due to root-project#13429 |
Ok, thanks for testing. Was worth a try, but then I have to get a debugger going... |
Right, I am trying to figure out why the reproducer does not work for you. Let's see if @smuzaffar can point out something on Monday. I think we might be missing one config step since the file is supposed to be public. Otherwise, I can give you access to one of our machines and set up a development area for you there. Sorry for the inconvenience! :) |
I think this testing PR can be closed, the associated change was merged into ROOT |
@hahnjo , thanks a lot for looking in to the issue and providing a the cmssw fix cms-sw/cmssw#42628 |
Testing if root-project#13463 solves root-project#13429