Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds the ability to use Fully-Qualified Domain Name for PLC address #12

Merged
merged 4 commits into from
Mar 29, 2018
Merged

Adds the ability to use Fully-Qualified Domain Name for PLC address #12

merged 4 commits into from
Mar 29, 2018

Conversation

patrickjmcd
Copy link
Collaborator

@patrickjmcd patrickjmcd commented Mar 29, 2018

enip.connect and Controller.connect can accept FQDN provided it resolves to an IP Address

Description, Motivation, and Context

Allows access to PLC's with FQDN

How Has This Been Tested?

  • npm run test:local passes
  • functional test passes

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • This is a work in progress, and I want some feedback (If yes, please mark it in the title -> e.g. [WIP] Some awesome PR title)

Related Issue

Fix #11

- updates `enip.connect` to allow FQDN provided it resolves to an IP address
- also increments version to v1.1.4
@patrickjmcd
Copy link
Collaborator Author

Functional test worked for both IP address and FQDN

@coveralls
Copy link

Pull Request Test Coverage Report for Build 51

  • 1 of 8 (12.5%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.3%) to 53.122%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/enip/index.js 1 8 12.5%
Totals Coverage Status
Change from base Build 50: -0.3%
Covered Lines: 462
Relevant Lines: 837

💛 - Coveralls

@cmseaton42
Copy link
Owner

merging this, ill add tests with a mass refactor soon

@cmseaton42 cmseaton42 added enhancement New feature or request new feature labels Mar 29, 2018
@cmseaton42 cmseaton42 merged commit b79d6ab into cmseaton42:master Mar 29, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request new feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow use of Fully-Qualified Domain Name instead of IP Address
3 participants