Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Warden Praetorian rework (tm) #7607

Merged
merged 61 commits into from
Feb 7, 2025
Merged

Conversation

Red-byte3D
Copy link
Member

@Red-byte3D Red-byte3D commented Nov 17, 2024

About the pull request

Reworks warden in to a more melee focused support caste, i need this tmd to see the castes shortcomings and if some things are busted to expand on it further.

Explain why it's good for the game

A caste like warden is un-fun to play against, in many circumstances anything that ! instantly ! gives you healing is really hard to "counter" and strong, and warden is built in such a manner that you can practically always just sit back spitting and being in safety while getting reserves. (especially with warding)

While you do have to get in close to heal somebody, majority of the time it just doesnt matter as you're getting in and out and your healing heals you and the person. While such a powerful ability would be fine otherwise, theres barely any risk involved in most cases and i think it's uninteresting to have such an un-involved strain be this powerful.

Valkyrie tries to remedy this by adding a more in-your-face sort of gameplay that makes it very deadly in cqc, the drawback being you have to get close. Removing the biggest problem of the instant heal, you have better buffs like rejuvenation on a bigger scale, armor buffs that apply both to you and a target, and heal per slash which isnt instant and not major enough to mean that you'll be surviving forever.

Testing Photographs and Procedure

Screenshots & Videos

Put screenshots and videos here with an empty line between the screenshots and the <details> tags.

Changelog

🆑
balance: Reworks warden into the Valkyrie
add: Valkyrie tail stab extuingishes people you stab. This goes for /anything/ so you can save caps on fire or your allies.
add: Tantrum ; You can click on a xenomorph to give them [15] armor, while giving yourself [10] armor, during tantrum your slashes heal more. This lasts 3 seconds for the target, 5 seconds for yourself.
add: High Gallop: An ability that knocks people down infront of you, in a 2x3 radius. Also sends back grenades.
add: Fight or Flight: A ranged rejuvenation that rejuvenates (removes stuns, slows weakens etc etc) scaling its range with your rage
add: Valkyrie slashes heal you and people 3 tiles next to you at a 15 to yourself and 15 to allies, while BUFFED (red outline) 30 to yourself and 30 to allies
/:cl:

@cm13-github cm13-github added the Merge Conflict PR can't be merged because it touched too much code label Nov 17, 2024
@cm13-github
Copy link
Contributor

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@cmss13-ci cmss13-ci bot added Feature Feature coder badge Balance You need to be a professional veteran game maintainer to comprehend what is being done here. labels Nov 17, 2024
@Red-byte3D
Copy link
Member Author

i need soembody to run my checks

@Drulikar
Copy link
Contributor

i need soembody to run my checks

Checks cannot run on a PR w/ conflicts

@cm13-github
Copy link
Contributor

Conflicts have been resolved. A maintainer will review the pull request shortly.

@cm13-github cm13-github removed the Merge Conflict PR can't be merged because it touched too much code label Nov 17, 2024
@cuberound
Copy link
Contributor

cuberound commented Nov 17, 2024

I might have missed it and it is already done, but perhaps with the armor make it unable to stack before some silly goose comes out with 100 armor after 3 preas power up (and welp it is not intended to work that way)

@Red-byte3D Red-byte3D marked this pull request as draft November 17, 2024 19:38
Copy link
Contributor

@Drulikar Drulikar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(You can batch changes in the Files changed tab)

@cuberound
Copy link
Contributor

to help you with balancing the armor values as welp... armor behaves in unexpected ways and is hard to find it. simplified dmg for ranged attacks on xeno is dmg/(1.0525^((armor-ap)/5)) dmg is dmg * 0.95^((armor-ap)/5) and there if further reduction is the reduced dmg is less then armor-ap, so be careful when adjusting armor values and be aware of that

cm13-github added a commit that referenced this pull request Feb 3, 2025
cm13-github added a commit that referenced this pull request Feb 3, 2025
cm13-github added a commit that referenced this pull request Feb 3, 2025
cm13-github added a commit that referenced this pull request Feb 4, 2025
@cm13-issue-bot cm13-issue-bot mentioned this pull request Feb 4, 2025
cm13-github added a commit that referenced this pull request Feb 5, 2025
cm13-github added a commit that referenced this pull request Feb 5, 2025
cm13-github added a commit that referenced this pull request Feb 5, 2025
cm13-github added a commit that referenced this pull request Feb 5, 2025
cm13-github added a commit that referenced this pull request Feb 5, 2025
@Willzadl Willzadl mentioned this pull request Feb 5, 2025
3 tasks
cm13-github added a commit that referenced this pull request Feb 5, 2025
cm13-github added a commit that referenced this pull request Feb 5, 2025
cm13-github added a commit that referenced this pull request Feb 5, 2025
cm13-github added a commit that referenced this pull request Feb 5, 2025
cm13-github added a commit that referenced this pull request Feb 6, 2025
@Strobia

This comment was marked as outdated.

@Red-byte3D Red-byte3D requested a review from hry-gh February 7, 2025 20:36
@hry-gh hry-gh added this pull request to the merge queue Feb 7, 2025
Merged via the queue into cmss13-devs:master with commit 4abf129 Feb 7, 2025
28 checks passed
cmss13-ci bot added a commit that referenced this pull request Feb 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Balance You need to be a professional veteran game maintainer to comprehend what is being done here. Feature Feature coder badge Needs Testing Need to test it on the guinea pigs (production server) Stale beg a maintainer to review your PR Testmerge Candidate we'll test this while you're asleep and the server has 10 players
Projects
Status: Merged
Development

Successfully merging this pull request may close these issues.