"Don't waste resources" Pamphlets changes QOL #8272
Draft
+16
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Red-byte3D
reviewed
Jan 29, 2025
cmss13-ci
bot
added
Quality of Life
harryob
requested changes
Jan 31, 2025
Comment on lines
+53
to
+63
| if(.) | ||
| var/datum/character_trait/skills/skill_trait = trait | ||
| if(istype(skill_trait)) | ||
| if(user.skills.get_skill_level(skill_trait.skill) < skill_trait.skill_cap) | ||
| return | ||
|
|
||
| if(user.skills.get_skill_level(skill_trait.secondary_skill) < skill_trait.secondary_skill_cap) | ||
| return | ||
|
|
||
| to_chat(user, SPAN_WARNING("This pamphlet is useless for you!")) | ||
| return FALSE |
There was a problem hiding this comment.
Suggested change
| if(.) | |
| var/datum/character_trait/skills/skill_trait = trait | |
| if(istype(skill_trait)) | |
| if(user.skills.get_skill_level(skill_trait.skill) < skill_trait.skill_cap) | |
| return | |
| if(user.skills.get_skill_level(skill_trait.secondary_skill) < skill_trait.secondary_skill_cap) | |
| return | |
| to_chat(user, SPAN_WARNING("This pamphlet is useless for you!")) | |
| return FALSE | |
| if(!.) | |
| return | |
| var/datum/character_trait/skills/skill_trait = trait | |
| if(istype(skill_trait)) | |
| if(user.skills.get_skill_level(skill_trait.skill) < skill_trait.skill_cap) | |
| return | |
| if(user.skills.get_skill_level(skill_trait.secondary_skill) < skill_trait.secondary_skill_cap) | |
| return | |
| to_chat(user, SPAN_WARNING("This pamphlet is useless for you!")) | |
| return FALSE |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About the pull request
No more wasting rare pamphlets without earning skills, you can't use it, if you aint getting skills
Explain why it's good for the game
No more skill issue? Thin ref
Also, CO smartgun skill... thank for that bug sended to downstream, now I come here to krill somebody...
Changelog
🆑
qol: Pamphlets skill check on increase, you can't spend them if they can't increase your skills
fix: Removed magic number on CO smartgun skill
/:cl: