Fixes a few cases of round() being floor() #8348
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cmss13-ci
bot
added
the
Missing Changelog
hry-gh
approved these changes
Feb 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About the pull request
So,
round(), if only provided 1 arg, is actuallyfloor(). This behavior is kept in solely because it's legacy behavior that code may depend on. As such, I'm moving our 4 cases of it to not use this behavior.A thank you to Kapu for providing the regex
\bround\s*\((\s*[^,()]*\s*\))to help find these cases.Explain why it's good for the game
Clarifies a few edge cases to be less ambiguous and depend less on deprecated legacy behavior.