Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

King Fix #8372

Closed
wants to merge 5 commits into from
Closed

King Fix #8372

wants to merge 5 commits into from

Conversation

Lukas-Seltz
Copy link
Contributor

@Lukas-Seltz Lukas-Seltz commented Feb 5, 2025

Adds a statement for when the King is dead it will not trigger the code stunning xenomorphs or humans

About the pull request

fixes: #6464
Adds a check for when the king is dead it will not trigger the procs that stun xenomorphs and marines.

Explain why it's good for the game

getting stunned by Dead corpse == bad

Testing Photographs and Procedure

Screenshots & Videos

Put screenshots and videos here with an empty line between the screenshots and the <details> tags.

Changelog

🆑
fix: fixes the issue with king tackling humans and xenomorphs while dead
/:cl:

Adds a statement for when the King is dead it will not trigger the code stunning xenomorphs or humans
@cmss13-ci cmss13-ci bot added Fix Fix one bug, make ten more Code Improvement Make the code longer labels Feb 5, 2025
@Red-byte3D
Copy link
Member

just keeping the fix part of the cl is fine, lgtm

@zzzmike
Copy link
Contributor

zzzmike commented Feb 5, 2025

linking issue - should solve #6464

@Lukas-Seltz Lukas-Seltz changed the title King Fix fixes: #6464 Feb 5, 2025
@Lukas-Seltz Lukas-Seltz changed the title fixes: #6464 King Fix Feb 5, 2025
Copy link
Member

@hry-gh hry-gh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this signal should just be unregistered on death

@hry-gh hry-gh marked this pull request as draft February 6, 2025 07:41
@Lukas-Seltz
Copy link
Contributor Author

I was doing it last night and Forest had me do it this way. I could change it to
if(carbon.is_dead())
continue
but it would accomplish the same thing the code here does.

@Lukas-Seltz Lukas-Seltz closed this Feb 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Code Improvement Make the code longer Fix Fix one bug, make ten more
Projects
Status: Closed
Development

Successfully merging this pull request may close these issues.

Dead king can trample mobs.
4 participants