Skip to content
This repository has been archived by the owner on Sep 27, 2019. It is now read-only.

Compilation fix #1439

Merged
merged 11 commits into from
Jun 28, 2018
Merged

Compilation fix #1439

merged 11 commits into from
Jun 28, 2018

Conversation

pervazea
Copy link
Contributor

Fix for issue #1438

@pervazea pervazea requested a review from mbutrovich June 28, 2018 15:25
Copy link
Contributor

@mbutrovich mbutrovich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm no SME on this, but the fix came from @tcm-marcel and this is his code, so I trust it. make check passed locally on AppleClang 9.1, assuming it gets through Travis and Jenkins then it LGTM.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.04%) to 77.189% when pulling af02bf0 on pervazea:comp_fix into 40acdf6 on cmu-db:master.

@tli2 tli2 merged commit 2b67714 into cmu-db:master Jun 28, 2018
@pervazea pervazea deleted the comp_fix branch June 28, 2018 18:07
mtunique pushed a commit to mtunique/peloton that referenced this pull request Apr 16, 2019
* Fix for python-six upgrade problem

Uninstall python-six on Ubuntu 14.04 so new version can be installed
during tensorflow and dependencies install


* - Fix for compilation error (from Marcel)
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants