Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Markov Check Test on same graph for different confusion matrix (Adj, AH, LG) for Gaussain DAG on Markov Blanket #1786

Merged
merged 1 commit into from
Jun 18, 2024

Conversation

vbcwonderland
Copy link
Collaborator

  1. Combine the tests on different confusion matrix so that they are now testing on the same randomly generated graph.

  2. Also improved print outs:
    2.1 Include target node information,
    2.2 Include the number of independence test p values feed into ADTest,
    2.3 Include whole graph precision and recall values using different confusion matrix.

@vbcwonderland vbcwonderland requested a review from jdramsey June 18, 2024 17:47
@ps7z
Copy link
Collaborator

ps7z commented Jun 18, 2024 via email

@jdramsey
Copy link
Collaborator

Peter, I may need to push these to development before you can clone them; they currently in a pull request.

Joe

Copy link
Collaborator

@jdramsey jdramsey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@jdramsey jdramsey merged commit 491d667 into development Jun 18, 2024
@jdramsey jdramsey deleted the vbc-2024-06-18 branch June 18, 2024 18:46
@jdramsey
Copy link
Collaborator

@ps7z OK these are now in development. By the way, @vbcwonderland, you may consider adding Peter to the pull request reviewers so he can see the changes.

Joe

@vbcwonderland
Copy link
Collaborator Author

Thank you Joe! I will make sure Peter gets the latest one in his local repo

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants