Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(*): validate parameter default against its definition #254

Merged
merged 4 commits into from
May 27, 2021

Conversation

vdice
Copy link
Member

@vdice vdice commented May 17, 2021

  • Adds validation against default parameter values when defined

This can be used to catch validation errors at build-time, rather than runtime (which #252 adds)

@vdice vdice requested a review from carolynvs May 17, 2021 19:03
Signed-off-by: Vaughn Dice <[email protected]>
bundle/parameters.go Show resolved Hide resolved
bundle/parameters.go Outdated Show resolved Hide resolved
bundle/parameters.go Outdated Show resolved Hide resolved
Copy link
Contributor

@carolynvs carolynvs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vdice vdice requested a review from radu-matei May 25, 2021 15:06
@vdice vdice merged commit 9c062fe into cnabio:main May 27, 2021
@vdice vdice deleted the feat/validate-param branch May 27, 2021 17:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants