Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

exclude Out from json marshalling in Operation #48

Closed
wants to merge 1 commit into from
Closed

exclude Out from json marshalling in Operation #48

wants to merge 1 commit into from

Conversation

simongdavies
Copy link
Contributor

fixes #47

silvin-lubecki
silvin-lubecki reviewed Jun 24, 2019
View reviewed changes
Copy link
Contributor

@silvin-lubecki silvin-lubecki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we also add a marshaling / unmarshaling test on this struct then?

@jeremyrickard
Copy link
Member

@simongdavies agree with @silvin-lubecki. Could you add some tests around this?

@simongdavies simongdavies deleted the fixjsonmarshall branch June 27, 2019 19:09
@simongdavies simongdavies mentioned this pull request Jun 27, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@silvin-lubecki silvin-lubecki silvin-lubecki left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Operation struct includes Out field when marshaled to son
3 participants
@simongdavies @jeremyrickard @silvin-lubecki