Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix a nil pointer deference in bundle.ValuesOrDefaults #50

Merged
merged 1 commit into from
Jun 25, 2019

Conversation

jcsirot
Copy link
Contributor

@jcsirot jcsirot commented Jun 25, 2019

bundle.ValuesOrDefaults failed with a panic due to a nil pointer dereference when no parameters are defined in the bundle passed to the function.

bundle/bundle.go Outdated Show resolved Hide resolved
… no parameters defined in the bundle

Signed-off-by: Jean-Christophe Sirot <[email protected]>
@jcsirot jcsirot force-pushed the fix-nil-pointer-default-value branch from ce49f34 to e0e76cf Compare June 25, 2019 13:58
Copy link
Contributor

@silvin-lubecki silvin-lubecki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

Copy link
Member

@jeremyrickard jeremyrickard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants