Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update the ParameterDefinition struct with the 'immutable' field #62

Merged
merged 1 commit into from
Jul 18, 2019
Merged

Update the ParameterDefinition struct with the 'immutable' field #62

merged 1 commit into from
Jul 18, 2019

Conversation

jcsirot
Copy link
Contributor

@jcsirot jcsirot commented Jul 17, 2019

Update the ParameterDefinition struct with the 'immutable' field and update the marshaling test.
Fixes #56

silvin-lubecki
silvin-lubecki approved these changes Jul 18, 2019
View reviewed changes
Copy link
Contributor

@silvin-lubecki silvin-lubecki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@silvin-lubecki silvin-lubecki merged commit acbc0d1 into cnabio:master Jul 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@silvin-lubecki silvin-lubecki silvin-lubecki approved these changes

@glyn glyn glyn approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[spec compliance] Add immutable flag to parameter definition
3 participants
@jcsirot @glyn @silvin-lubecki