Switch digest to contentDigest in the json tags
#75
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vdice
approved these changes
Jul 23, 2019
glyn
reviewed
Jul 24, 2019
testdata/bundles/digest.json
Outdated
| "schemaVersion": "99.99", | ||
| "images": { | ||
| "my-microservice": { | ||
| "contentDigest": "sha256:aaaaaaaaaaaa...", |
There was a problem hiding this comment.
On the basis that open source tests are a form of documentation, I'd prefer it if we used a proper content digest e.g. "sha256:deadbeefdeadbeefdeadbeefdeadbeefdeadbeefdeadbeefdeadbeefdeadbeef" (or a vegetarian alternative).
There was a problem hiding this comment.
Yep, good idea. I took this directly from one of the examples in the spec examples directory.
glyn
reviewed
Jul 24, 2019
testdata/bundles/digest.json
Outdated
| }, | ||
| "invocationImages": [ | ||
| { | ||
| "contentDigest": "sha256:aaaaaaa...", |
There was a problem hiding this comment.
See previous comment about proper content digest, but use a distinct one here.
glyn
reviewed
Jul 24, 2019
testdata/bundles/digest.json
Outdated
| } | ||
| } | ||
| } | ||
| } |
There was a problem hiding this comment.
nit: add newline to keep github view clean?
glyn
reviewed
Jul 24, 2019
glyn
reviewed
Jul 24, 2019
glyn
reviewed
Jul 24, 2019
glyn
reviewed
Jul 24, 2019
bundle/bundle_test.go
Outdated
| //images[] should have exactly 1 values | ||
| _, ok := bundle.Images["my-microservice"] | ||
| require.True(t, ok, "there should been an image named my-microservice in the bundle") | ||
| // the image digest should equal sha256:aaaaaaaaaaaa... |
There was a problem hiding this comment.
nit: best to delete comments which merely repeat what the code says.
glyn
suggested changes
Jul 24, 2019
This PR swaps `contentDigest` in place of `digest` in the json/mapstructure tags for the BaseImage type. Adds a test for marashalling as well. Fixes cnabio#59
glyn
approved these changes
Jul 24, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR swaps
contentDigestin place ofdigestin the json/mapstructure tags for the BaseImage type. Adds a test for marashalling as well.Fixes #59