Add immutable flag to parameters. #212
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeremyrickard
requested review from
glyn,
simonferquel,
technosophos and
radu-matei
|
Does the JSON Schema need an update? |
|
@technosophos indeed it does! Sorry I thought I opened this as a Draft PR. working on the schema still :( |
jeremyrickard
force-pushed
the
immutable-param
branch
from
1700a5b to
cd8a1f1
Compare
|
@technosophos Updated the PR to add the schema addition and updated the 101.02 to add an explicit |
jeremyrickard
force-pushed
the
immutable-param
branch
from
cd8a1f1 to
82d8919
Compare
jlegrone
approved these changes
Jul 9, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds an immutable flag to the parameter definition in
101-bundle-json.mdand adds wording to103-bundle-runtime.mdto indicate that if an immutable parameter value is given at any time other than runtime, it should result in an error.Closes #181