Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add aswf.yaml #1420

Merged
merged 3 commits into from
Feb 6, 2024
Merged

Add aswf.yaml #1420

merged 3 commits into from
Feb 6, 2024

Conversation

jmertic
Copy link
Contributor

@jmertic jmertic commented Feb 2, 2024


Signed-off-by: John Mertic <[email protected]>
Copy link
Contributor

@tegioz tegioz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @jmertic!

Could you please add the corresponding check sets for each repository?

@jmertic
Copy link
Contributor Author

jmertic commented Feb 6, 2024

Hey - happy to do this - but since we don't plan to use clomonitor right now, what is the minimal level of checks we should do?

@tegioz
Copy link
Contributor

tegioz commented Feb 6, 2024

Oh cool, then instead of adding the checks set, it'd be best to exclude them from CLOMonitor. You can achieve that by adding the following to each repository:

exclude:
  - clomonitor

Signed-off-by: John Mertic <[email protected]>
Signed-off-by: John Mertic <[email protected]>
@jmertic
Copy link
Contributor Author

jmertic commented Feb 6, 2024

Sounds good - take a look and see if that is better now.

Copy link
Contributor

@tegioz tegioz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, looks good to me 👍

@tegioz tegioz merged commit 91fd8e3 into cncf:main Feb 6, 2024
5 checks passed
@jmertic jmertic deleted the patch-1 branch February 6, 2024 17:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants