Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Rodolfo Martinez to Spanish approver team #1191

Closed

Conversation

electrocucaracha
Copy link
Collaborator

Given his active collaboration in Spanish localization team, this PR recognizes the effort made by @ramrodo and promotes him to the approver role.

/cc @raelga @krol3

@netlify
Copy link

netlify bot commented Aug 9, 2022

Deploy Preview for cncfglossary ready!

Name Link
🔨 Latest commit a1d581c
🔍 Latest deploy log https://app.netlify.com/sites/cncfglossary/deploys/62f2d4866997ca0008b2873d
😎 Deploy Preview https://deploy-preview-1191--cncfglossary.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@jihoon-seo jihoon-seo added lang/es for Spanish maintainers Use this label if PR requires maintainers to take action labels Aug 10, 2022
@seokho-son seokho-son added the hold Wait, please do not proceed this yet label Aug 10, 2022
@seokho-son
Copy link
Collaborator

Hi @electrocucaracha @raelga

Thank you for this suggestion ! :)

In a maintainers' meeting, we have decided the maximum approvers for a l10n team is up to four (for now).
Please understand it is to minimize permission maintenance issue. Without the permission, contributors still can contribute.

In case of Spanish team, there are three existing approvers. If we accept both PR #1191 and PR #1192 , the number of team approver will be five.

We've applied this maximum approvers to other l10n teams like this .

I hope to say that not every l10n volunteers need to be an approver. (without being an approver, folks can provide review)
Could Spanish team can select one approver among the candidates ?

Changing approvers may be possible based on their activities, but we don't have a strict policy on that yet.
(The maximum can be changed by a consent in Glossary working group meeting. So, if Spanish team really wants to have more than four approvers please suggest with a reasonable explanation)

@electrocucaracha
Copy link
Collaborator Author

In a maintainers' meeting, we have decided the maximum approvers for a l10n team is up to four (for now). Please understand it is to minimize permission maintenance issue. Without the permission, contributors still can contribute.

Hi @seokho-son, thanks for letting us about that decision, I wasn't aware of. We can discuss it in our next weekly meeting and find a resolution. In the meantime, I will keep both PRs open.

@raelga
Copy link
Collaborator

raelga commented Aug 23, 2022

After reviewing this during the weekly meeting, @92nqb will join to the approver team instead of @ramrodo.

@raelga raelga closed this Aug 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hold Wait, please do not proceed this yet lang/es for Spanish maintainers Use this label if PR requires maintainers to take action
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants