Add Hindi approvers in CODEOWNERS #298
Closed
+1
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jayesh-srivastava
requested review from
caniszczyk,
CathPag and
JasonMorgan
as code owners
|
✔️ Deploy Preview for cncfglossary ready! 🔨 Explore the source changes: c49b4e0 🔍 Inspect the deploy log: https://app.netlify.com/sites/cncfglossary/deploys/61d959a4e938990007b851b5 😎 Browse the preview: https://deploy-preview-298--cncfglossary.netlify.app |
|
We also need to add a block for Hindi in config.toml |
|
As @seokho-son mentioned on Slack, we are still testing the process with the Korean team, so we'll hold on merging this until that is the process is confirmed as working well. |
anubha-v-ardhan
suggested changes
Jan 21, 2022
There was a problem hiding this comment.
@jayesh-srivastava I believe you can close this PR as this change is being done by #342 for all localizations
|
Let me close this PR :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A task based on the issue #297 (Initiate Hindi Localization Team)