Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update settings.yml for dev-hi branch protection and approvers #299

Closed

Conversation

anubha-v-ardhan
Copy link
Contributor

This PR updates settings.yml with dev-hi branch protection rule and approvers.

@netlify
Copy link

netlify bot commented Jan 9, 2022

✔️ Deploy Preview for cncfglossary ready!

🔨 Explore the source changes: 99601b9

🔍 Inspect the deploy log: https://app.netlify.com/sites/cncfglossary/deploys/61da7eaa44c1b300073690a1

😎 Browse the preview: https://deploy-preview-299--cncfglossary.netlify.app

@seokho-son seokho-son added the hold Wait, please do not proceed this yet label Jan 9, 2022
@seokho-son
Copy link
Collaborator

@anubha-v-ardhan The current setting for dev-branch does not work properly.
I think this PR would not work properly too.
We still need to check permission issue. (at least PR #296 needs to be merged and tested)
Let me close this PR to prevent accidental approvals :)

@anubha-v-ardhan
Copy link
Contributor Author

Oh!, no issues let us wait for #296 then

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hold Wait, please do not proceed this yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants