-
Notifications
You must be signed in to change notification settings - Fork 555
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add localization team approvers (ar bn es pt ko) #432
Conversation
✔️ Deploy Preview for cncfglossary ready! 🔨 Explore the source changes: 12a2162 🔍 Inspect the deploy log: https://app.netlify.com/sites/cncfglossary/deploys/6207ed9295e2250008326a51 😎 Browse the preview: https://deploy-preview-432--cncfglossary.netlify.app |
Understood the responsibility properly @seokho-son 😁 |
Understood the overall policy 😅 @seokho-son |
Got it @seokho-son. Understood the overall policy. |
Understood the overall policy. |
Understood the overall policy. 🎉 💙 |
Understood @seokho-son 👍 . |
Understood @seokho-son |
Understood the overall policy 👍 |
Thank you @seokho-son! Understood the overall policy. |
Please accept me as an approver for Arabic language |
Understood the policy, Thank you. 🚀 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome!
Based on l10n team initiation requests, I added localization approvers for each language.
(https://github.com/cncf/glossary/projects/2)
[Important]
It is to make l10n approvers manage (merge) PRs for l10n contributions in your development branch.
Merging a PR to the
main
branch by l10n approvers is restricted.Even if they are possible to review a PR to the
main
branch and give an approval to the PR, they should not approve the PR.So, please do not approve if a PR is not related with your localization.
[PR merge condition to main branch]
[PR merge condition to dev-xx l10n branch (dev-ko)]
I hope to note that we are using the CODEOWNERS to automatically request a review to appropriate persons.
(https://docs.github.com/en/repositories/managing-your-repositorys-settings-and-features/customizing-your-repository/about-code-owners#about[…]owners)
The actual access permission can be configured from the repository setting (cncf/glossary repo).