Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add karmada lfx 2024 03-Sep-Nov projects #1272

Merged
merged 3 commits into from
Jul 31, 2024
Merged

add karmada lfx 2024 03-Sep-Nov projects #1272

merged 3 commits into from
Jul 31, 2024

Conversation

XiShanYongYe-Chang
Copy link
Contributor

No description provided.

@XiShanYongYe-Chang
Copy link
Contributor Author

/hold

@XiShanYongYe-Chang
Copy link
Contributor Author

/cc @RainbowMango

@nate-double-u
Copy link
Member

Thanks for this @XiShanYongYe-Chang, i see your hold and will remove the label when you're ready.

Also, we've extended the proposal window, project proposals are now due July 30, 2024 (#1263)

@XiShanYongYe-Chang
Copy link
Contributor Author

Thanks a lot @nate-double-u
It's ready now.
/hold-cancel

@XiShanYongYe-Chang
Copy link
Contributor Author

/hold cancel

@XiShanYongYe-Chang
Copy link
Contributor Author

/remove-hold

@XiShanYongYe-Chang
Copy link
Contributor Author

Hi @nate-double-u I have fixed the merge conflict, and I am trying to remove the hold label, but it didn't success. Can you help me remove the hold label? Thanks~

@aliok aliok removed the hold label Jul 24, 2024
@aliok
Copy link
Member

aliok commented Jul 24, 2024

hi @XiShanYongYe-Chang

I removed the hold now. After merging another PR, there's a new conflict which I will resolve in a moment.

We need approval / 👍 from a person listed in the maintainers list for Karmada:
https://raw.githubusercontent.com/cncf/foundation/main/project-maintainers.csv

@XiShanYongYe-Chang
Copy link
Contributor Author

Thanks @aliok

@XiShanYongYe-Chang
Copy link
Contributor Author

/assign @RainbowMango

@nate-double-u
Copy link
Member

Hi @nate-double-u I have fixed the merge conflict, and I am trying to remove the hold label, but it didn't success. Can you help me remove the hold label? Thanks~

Sorry, it's not an automatic system 😅

@RainbowMango
Copy link
Contributor

Thanks @XiShanYongYe-Chang for submitting this and thanks to @aliok @nate-double-u for the help.

@aliok
Copy link
Member

aliok commented Jul 29, 2024

@warjiang and @zhzhuang-zju

Can you give us 👍 please?

Then we can merge.

@nate-double-u
Copy link
Member

Hi, I'm still looking for a 👍 or approval from @zhzhuang-zju to confirm their participation before we can merge this in.

The PR was opened before the due date, so don't worry about not getting this merged before today. Even if it's a couple days late we can load this into the LFX platform but it may have to go in on the second pass (which means it may miss being available for the first day or 2 of candidate applications).

@nate-double-u
Copy link
Member

@XiShanYongYe-Chang, could you remove the files in the .idea folder?

@nate-double-u
Copy link
Member

I see we have a 👍 from @zhzhuang-zju, so we can merge this as soon as we remove the .idea folder files.

nate-double-u
nate-double-u approved these changes Jul 31, 2024
View reviewed changes
Copy link
Member

@nate-double-u nate-double-u left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I had to do a conflict resolution, so i just removed the .idea folder.

Thanks everyone!

@nate-double-u nate-double-u merged commit 3255931 into cncf:main Jul 31, 2024
2 checks passed
@XiShanYongYe-Chang
Copy link
Contributor Author

could you remove the files in the .idea folder?

I'm sorry, I just see it, Thanks a lot @nate-double-u

@XiShanYongYe-Chang XiShanYongYe-Chang deleted the karmada branch January 27, 2025 09:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nate-double-u nate-double-u nate-double-u approved these changes

Assignees
No one assigned
Labels
2024 lfx mentorship Term 3: Sept-Nov
Projects
TAG Contributor Strategy Project Board
Status: ✅ Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@XiShanYongYe-Chang @nate-double-u @aliok @RainbowMango