Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added config for gitea to support webhooks trigger #388

Merged
merged 4 commits into from
Sep 16, 2024

Conversation

mmaroth
Copy link
Contributor

@mmaroth mmaroth commented Sep 16, 2024

Gitea webhook event POST call is failing with webhook can only call allowed HTTP servers (check your webhook.ALLOWED_HOST_LIST setting), fixing this issue by adding webhook settings to allow private IPs and Skip TLS Verify.

@mmaroth mmaroth force-pushed the gitea-webhooks-support branch from 2d632a4 to 70cad93 Compare September 16, 2024 20:48
Copy link
Collaborator

@nabuskey nabuskey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Gitea supports webhook a few configurations. We use private as the default because most of what we do are in-cluster. https://docs.gitea.com/administration/config-cheat-sheet?_highlight=webhook/administration/config-cheat-sheet#webhook-webhook

Skipping TLS verification shouldn't happen but we don't have gitea configured to use the TLS cert yet.

@nabuskey nabuskey merged commit 5febab5 into cnoe-io:main Sep 16, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants