Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: rapid bar #48

Merged
merged 5 commits into from
Oct 31, 2023
Merged

feat: rapid bar #48

merged 5 commits into from
Oct 31, 2023

Conversation

elrrrrrrr
Copy link
Member

@elrrrrrrr elrrrrrrr commented Oct 30, 2023 •
edited
Loading

console.time 替换为进度条，目前选取 [download, fsMeta, bootstrap, mount, overlay] 阶段进行展示

bar.mp4
  • 修复 clean workspaces 项目时，子路径未 clean 的问题
  • hdiutil fallback 采用 umount -f 替换实现
  • fsMeta 及 bootstrap 目前会卡住输出，后续优化

@socket-security
Copy link

New dependencies detected. Learn more about Socket for GitHub ↗︎

Packages Version New capabilities Transitives Size Publisher
cli-progress 3.12.0 None +0 62.2 kB andidittrich

@elrrrrrrr elrrrrrrr force-pushed the rapid-bars branch 3 times, most recently from 2e4984f to 8541fd5 Compare October 31, 2023 03:57
@elrrrrrrr elrrrrrrr added the enhancement New feature or request label Oct 31, 2023
@elrrrrrrr elrrrrrrr requested a review from killagu October 31, 2023 03:59
@elrrrrrrr elrrrrrrr marked this pull request as ready for review October 31, 2023 04:02
@elrrrrrrr elrrrrrrr marked this pull request as draft October 31, 2023 04:02
@killagu
Copy link
Contributor

killagu commented Oct 31, 2023

CI 挂了。

killagu
killagu reviewed Oct 31, 2023
View reviewed changes
packages/cli/lib/download_dependency.js
@@ -43,23 +43,19 @@ async function download(options) {
const blobManager = new NpmBlobManager();
const entryListener = entryListenerFactory(blobManager);

console.time('[rapid] downloader new');
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这个最好不要删。有个长耗时在里面。

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

换成 debug？

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

改在 bar 里兼容，这样 ci 环境里的报错也能看到。

本地环境进度条能看到具体耗时和当前执行任务。

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

@elrrrrrrr elrrrrrrr marked this pull request as ready for review October 31, 2023 06:07
@elrrrrrrr elrrrrrrr requested a review from killagu October 31, 2023 07:43
killagu
killagu approved these changes Oct 31, 2023
View reviewed changes
Copy link
Contributor

@killagu killagu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@elrrrrrrr elrrrrrrr merged commit bb52985 into master Oct 31, 2023
13 checks passed
@elrrrrrrr elrrrrrrr deleted the rapid-bars branch October 31, 2023 08:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@killagu killagu killagu approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@elrrrrrrr @killagu