Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add support of clan tag #59

Merged
merged 7 commits into from
Sep 25, 2024
Merged

feat: add support of clan tag #59

merged 7 commits into from
Sep 25, 2024

Conversation

hexaaagon
Copy link
Contributor

@hexaaagon hexaaagon commented Sep 17, 2024

hello! i've implement a feature for a clan tag, i'm not sure if its match the design.
{BF1A1044-012A-4439-AC10-6F80026137FC}

Copy link

vercel bot commented Sep 17, 2024

@hexaaagon is attempting to deploy a commit to the Conrad's projects Team on Vercel.

A member of the Team first needs to authorize it.

@dustinrouillard
Copy link
Contributor

dustinrouillard commented Sep 20, 2024

Would wait a couple days till phin gets the new lanyard commits deployed as I've stringify'd the clan guild id now as it should be, when that's done I would also remove the un-needed function and extra dependency, and then it can be merged if conrad approves in the end.

Latest Lanyard was deployed, so that function can be removed.

Copy link

vercel bot commented Sep 23, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
lanyard-profile-readme ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 23, 2024 5:49pm

@cnrad
Copy link
Owner

cnrad commented Sep 23, 2024

This all looks really good! Just a single nitpick though, the hideClanTag query param could be renamed to hideClan for simplicity - it still gets the point across and is easier to remember imo. Once you do that, I'll merge

@hexaaagon
Copy link
Contributor Author

This all looks really good! Just a single nitpick though, the hideClanTag query param could be renamed to hideClan for simplicity - it still gets the point across and is easier to remember imo. Once you do that, I'll merge

alright, its done :)

@cnrad cnrad merged commit 3158aaf into cnrad:main Sep 25, 2024
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants