Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent duplicate Breeds or Versions to be in the data #35

Merged
merged 1 commit into from
Jun 30, 2021

Conversation

SchoolGuy
Copy link
Member

This needs to be rebased after #34 is merged.

This is a splitout of #31

@SchoolGuy SchoolGuy added the enhancement New feature or request label Jun 22, 2021
@SchoolGuy SchoolGuy added this to the v1.0.0 milestone Jun 22, 2021
@SchoolGuy SchoolGuy requested a review from nodeg June 22, 2021 11:54
@SchoolGuy SchoolGuy marked this pull request as draft June 22, 2021 11:54
@codecov
Copy link

codecov bot commented Jun 22, 2021

Codecov Report

Merging #35 (bd76264) into main (deee448) will decrease coverage by 0.00%.
The diff coverage is 57.14%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #35      +/-   ##
==========================================
- Coverage   50.51%   50.51%   -0.01%     
==========================================
  Files           4        4              
  Lines         675      681       +6     
==========================================
+ Hits          341      344       +3     
- Misses        334      337       +3     
Flag Coverage Δ
unittests 50.51% <57.14%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
libcobblersignatures/signatures.py 96.00% <50.00%> (-0.94%) ⬇️
libcobblersignatures/models/osbreed.py 86.53% <60.00%> (-3.05%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update deee448...bd76264. Read the comment docs.

@SchoolGuy SchoolGuy mentioned this pull request Jun 22, 2021
@SchoolGuy SchoolGuy force-pushed the usability/prevent-duplicate-keys branch from 05e8f59 to bd76264 Compare June 30, 2021 15:53
@SchoolGuy SchoolGuy marked this pull request as ready for review June 30, 2021 15:54
@SchoolGuy SchoolGuy requested a review from a team June 30, 2021 15:54
Copy link

@vzhestkov vzhestkov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@SchoolGuy SchoolGuy merged commit d7cd46b into main Jun 30, 2021
@SchoolGuy SchoolGuy deleted the usability/prevent-duplicate-keys branch June 30, 2021 16:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Development

Successfully merging this pull request may close these issues.

3 participants