Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: Add version replacement workflow #52

Merged
merged 1 commit into from
Jan 6, 2023
Merged

Conversation

@tiltingpenguin tiltingpenguin added the enhancement New feature or request label Jan 5, 2023
@codecov
Copy link

codecov bot commented Jan 5, 2023

Codecov Report

Base: 53.30% // Head: 53.36% // Increases project coverage by +0.06% 🎉

Coverage data is based on head (5b3de92) compared to base (fcc11cb).
Patch coverage: 100.00% of modified lines in pull request are covered.

❗ Current head 5b3de92 differs from pull request most recent head 612cc8c. Consider uploading reports for the commit 612cc8c to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #52      +/-   ##
==========================================
+ Coverage   53.30%   53.36%   +0.06%     
==========================================
  Files           6        6              
  Lines         756      757       +1     
==========================================
+ Hits          403      404       +1     
  Misses        353      353              
Flag Coverage Δ
unittests 53.36% <100.00%> (+0.06%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
libcobblersignatures/__init__.py 94.56% <100.00%> (+0.05%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Member

@SchoolGuy SchoolGuy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. We shouldn't tag before we addressed the other release automation though.

@SchoolGuy SchoolGuy merged commit ef9620f into main Jan 6, 2023
@SchoolGuy SchoolGuy deleted the version-replacement branch January 6, 2023 19:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Development

Successfully merging this pull request may close these issues.

2 participants