New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

consoles: Allow configuring VNC #1973

Draft

mvollmer wants to merge 2 commits into cockpit-project:main from mvollmer:console-vnc-edit

Member

mvollmer commented Jan 14, 2025

Via the "Consoles" card, when the machine is off.

This is the minimum to get #1795 finished, IMO, and we should not try to do more. Anything on top happens in #1972 and elsewhere, at its own pace.

mvollmer added 2 commits

January 13, 2025 16:18


          consoles: Import VNC dialogs from cockpit-project#1795

eaf58a2


          consoles: Show VNC details also when VM is off

2842ed0

So that people can edit them or add VNC if it is missing.

mvollmer mentioned this pull request

Add "view, edit, and add Video devices" to detailspage #1795

Draft

Member Author

mvollmer commented Jan 14, 2025

There is more work to be done here, of course:

Optional password reveal in the dialogs.
Explicit option to select "auto" for the port instead of having to input -1.
Input validation in the dialogs, e.g. check if address is valid, check if port is in the required range
Wording change, I think it should be "Listening address" instead of "VNC address", etc, since we are configuring the server, not the client.
tests, coverage

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet