Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tumbleweed testing part 1 #21499

Merged
merged 3 commits into from
Jan 8, 2025

Conversation

Nykseli
Copy link
Contributor

@Nykseli Nykseli commented Jan 8, 2025

This the part 1 of #21335 (review)

These are the "boring" bits that don't fit anywhere else

Let us know if you need anymore changes. Hope you had a good break!

martinpitt
martinpitt previously approved these changes Jan 8, 2025
Copy link
Member

@martinpitt martinpitt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! LGTM, triggering tests. The leases ought to clean up after themselves, but as we don't do that right now either, it should be fine for now.

@martinpitt martinpitt dismissed their stale review January 8, 2025 14:13

test failures

@martinpitt
Copy link
Member

martinpitt commented Jan 8, 2025

The lease changes fail on other OSes; I'll have a look at that.

SludgeGirl and others added 3 commits January 8, 2025 15:38
This works better with OpenSUSE's AppArmor policy.
Some distros, like Tumbleweed, already have existing group called user
so it's better to create a group that's called something like bob
@martinpitt martinpitt force-pushed the tumbleweed-testing-1 branch from c476c58 to 4c4d740 Compare January 8, 2025 15:13
@martinpitt
Copy link
Member

Fixed.

@martinpitt martinpitt merged commit 1986ae8 into cockpit-project:main Jan 8, 2025
85 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants