Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not use redirects for latest binaries #157

Merged
merged 1 commit into from
Dec 30, 2022

Conversation

rail
Copy link
Member

@rail rail commented Dec 30, 2022

After we moved the edge CDN to GCS-backed Google CDN, the latest binaries became actual binaries, without redirects, as it was before.

This PR removes the redirect resolution logic.

I also pinned clrfmt to the version that doesn't use generics and added go-1.19 to the test matrix.

@rail rail requested a review from rafiss December 30, 2022 01:08
@rail rail self-assigned this Dec 30, 2022
@cockroach-teamcity
Copy link
Member

This change is Reviewable

@rail rail force-pushed the no-more-redirects branch 2 times, most recently from f30220a to f18353b Compare December 30, 2022 01:23
After we moved the edge CDN to GCS-backed Google CDN, the latest
binaries became actual binaries, without redirects, as it was before.

This PR removes the redirect resolution logic.
@rail rail force-pushed the no-more-redirects branch from f18353b to 4c999fd Compare December 30, 2022 01:27
@rafiss rafiss merged commit 07f15fe into cockroachdb:master Dec 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants