opt: remove no-op that adds extra columns to the needed set

Release note: None
cockroachdb · Jul 9, 2019 · 00c9100 · 00c9100
1 parent ff6ce77
commit 00c9100
Showing 1 changed file with 0 additions and 7 deletions.
diff --git a/pkg/sql/opt/norm/prune_cols.go b/pkg/sql/opt/norm/prune_cols.go
@@ -582,12 +582,5 @@ func (c *CustomFuncs) NeededMutationReturnCols(
 		returningColSet.Add(tabID.ColumnID(primaryIndex.Column(i).Ordinal))
 	}
 
-	// Deal with the the RETURNING * case.
-	if len(projections) == 0 && passthrough.Len() == 0 {
-		for i, n := 0, primaryIndex.ColumnCount(); i < n; i++ {
-			returningColSet.Add(tabID.ColumnID(primaryIndex.Column(i).Ordinal))
-		}
-	}
-
 	return returningColSet
 }