Skip to content

Commit

Permalink
roachtest: get bigger machines for alterpk-tpcc-250
Browse files Browse the repository at this point in the history
The test has been failing for a while now because we're operating very
close to memory limit. Usually, 3.3.2.6 expensive check query ends up
crashing the node, sometimes it hits SQL memory limit. I've been staring
at it for a while, but there is a discrepancy between the memory usage
reported in runtime stats in logs and the usage that shows up in heap
profiles (for example, I could see 8GB in the former and 3GB in the
latter), and I couldn't figure out where that gaps goes. I don't think
spending any more time on this issue is worthwhile, so this commit bumps
the machine type from cpu-16 to cpu-32 which doubles available RAM from
14.4 to 28.8.

Release note: None
  • Loading branch information
yuzefovich committed May 26, 2020
1 parent 440d6f5 commit 1b3e0d7
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion pkg/cmd/roachtest/alterpk.go
Original file line number Diff line number Diff line change
Expand Up @@ -179,7 +179,7 @@ func registerAlterPK(r *testRegistry) {
// Use a 4 node cluster -- 3 nodes will run cockroach, and the last will be the
// workload driver node.
MinVersion: "v20.1.0",
Cluster: makeClusterSpec(4, cpu(16)),
Cluster: makeClusterSpec(4, cpu(32)),
Run: func(ctx context.Context, t *test, c *cluster) {
runAlterPKTPCC(ctx, t, c, 250 /* warehouses */, true /* expensiveChecks */)
},
Expand Down

0 comments on commit 1b3e0d7

Please sign in to comment.