Skip to content

Commit

Permalink
logictest: skip MR configs under race outside ccl
Browse files Browse the repository at this point in the history
This commit skips under race a couple of MR logic tests that don't live
under the ccl folder. We've seen these time out a few times.

Release note: None
  • Loading branch information
yuzefovich committed Jan 17, 2025
1 parent f0f4243 commit 56dbe56
Show file tree
Hide file tree
Showing 4 changed files with 6 additions and 4 deletions.
4 changes: 2 additions & 2 deletions pkg/cmd/generate-logictest/main.go
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ type testFileTemplateConfig struct {
CockroachGoTestserverTest bool
Ccl bool
ForceProductionValues bool
SkipCclUnderRace bool
SkipUnderRace bool
UseHeavyPool useHeavyPoolCondition
Package, TestRuleName, RelDir string
ConfigIdx int
Expand Down Expand Up @@ -188,7 +188,7 @@ func (t *testdir) dump() error {
tplCfg.NumCPU = 3
}
if cfg.Name == "3node-tenant" || strings.HasPrefix(cfg.Name, "multiregion-") {
tplCfg.SkipCclUnderRace = true
tplCfg.SkipUnderRace = true
}
tplCfg.UseHeavyPool = useHeavyPoolNever
if strings.Contains(cfg.Name, "5node") ||
Expand Down
4 changes: 2 additions & 2 deletions pkg/cmd/generate-logictest/templates.go
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@ const templateText = `
{{- define "runLogicTest" }}
{{- if .LogicTest -}}
func runLogicTest(t *testing.T, file string) {
{{if and .SkipCclUnderRace .Ccl}}skip.UnderRace(t, "times out and/or hangs")
{{if .SkipUnderRace}}skip.UnderRace(t, "times out and/or hangs")
{{end}}skip.UnderDeadlock(t, "times out and/or hangs")
logictest.RunLogicTest(t, logictest.TestServerArgs{}, configIdx, filepath.Join(logicTestDir, file))
}
Expand All @@ -48,7 +48,7 @@ func runLogicTest(t *testing.T, file string) {
{{- define "runCCLLogicTest" }}
{{- if .CclLogicTest -}}
func runCCLLogicTest(t *testing.T, file string) {
{{if .SkipCclUnderRace}}skip.UnderRace(t, "times out and/or hangs")
{{if .SkipUnderRace}}skip.UnderRace(t, "times out and/or hangs")
{{end}}skip.UnderDeadlock(t, "times out and/or hangs")
logictest.RunLogicTest(t, logictest.TestServerArgs{}, configIdx, filepath.Join(cclLogicTestDir, file))
}
Expand Down

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

0 comments on commit 56dbe56

Please sign in to comment.