Skip to content

Commit

Permalink
Merge #55790
Browse files Browse the repository at this point in the history
55790: build: add bazel-3.7.0 to builder image r=irfansharif,jlinder a=otan

Resolves #55693 

Release note: None

Co-authored-by: Oliver Tan <[email protected]>
  • Loading branch information
craig[bot] and otan committed Oct 21, 2020
2 parents d775b98 + cf4de10 commit c638b8e
Show file tree
Hide file tree
Showing 3 changed files with 9 additions and 1 deletion.
2 changes: 1 addition & 1 deletion build/builder.sh
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
set -euo pipefail

image=cockroachdb/builder
version=20201001-110640
version=20201020-171515

function init() {
docker build --tag="${image}" "$(dirname "${0}")/builder"
Expand Down
4 changes: 4 additions & 0 deletions build/builder/Dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -224,8 +224,11 @@ RUN curl -fsSL https://deb.nodesource.com/gpgkey/nodesource.gpg.key | apt-key ad
&& echo 'deb https://packages.cloud.google.com/apt cloud-sdk-xenial main' | tee /etc/apt/sources.list.d/gcloud.list \
&& curl -fsSL https://dl-ssl.google.com/linux/linux_signing_key.pub | apt-key add - \
&& echo "deb [arch=amd64] https://dl.google.com/linux/chrome/deb/ stable main" | tee /etc/apt/sources.list.d/google.list \
&& echo "deb [arch=amd64] https://storage.googleapis.com/bazel-apt stable jdk1.8" | tee /etc/apt/sources.list.d/bazel.list \
&& curl https://bazel.build/bazel-release.pub.gpg | apt-key add - \
&& apt-get update

# bazel - build system
# ccache - speed up C and C++ compilation
# lsof - roachprod monitor
# netcat - roachprod monitor
Expand All @@ -237,6 +240,7 @@ RUN curl -fsSL https://deb.nodesource.com/gpgkey/nodesource.gpg.key | apt-key ad
# chrome - ui
# unzip - for installing awscli
RUN apt-get install -y --no-install-recommends \
bazel-3.7.0 \
ccache \
google-cloud-sdk \
lsof \
Expand Down
4 changes: 4 additions & 0 deletions pkg/testutils/lint/lint_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -1823,6 +1823,10 @@ func TestLint(t *testing.T) {
// Ignore types that can change by system.
stream.GrepNot(`pkg/util/sysutil/sysutil_unix.go:`),

// Ignore jemalloc issues warnings.
stream.GrepNot(`In file included from.*(start|runtime)_jemalloc\.go`),
stream.GrepNot(`include/jemalloc/jemalloc\.h`),

stream.GrepNot(`declaration of "?(pE|e)rr"? shadows`),
stream.GrepNot(`\.pb\.gw\.go:[0-9:]+: declaration of "?ctx"? shadows`),
stream.GrepNot(`\.[eo]g\.go:[0-9:]+: declaration of ".*" shadows`),
Expand Down

0 comments on commit c638b8e

Please sign in to comment.