CockroachDB doesn't return ErrorResponse if client sends a startup message with invalid database name

[giangpham712]

Describe the problem
With PosgreSQL, when client sends a startup message with invalid database name, the response will be ErrorResponse as specified here (https://www.postgresql.org/docs/current/protocol-flow.html). CockroachDB still returns a ReadyForQuery response

Additional context
This affects efcore.pg tests

@fqazi

Jira issue: CRDB-31206

[blathers-crl]

Hello, I am Blathers. I am here to help you get the issue triaged.

Hoot - a bug! Though bugs are the bane of my existence, rest assured the wretched thing will get the best of care here.

I was unable to automatically find someone to ping.

If we have not gotten back to your issue within a few business days, you can try the following:

• Join our community slack channel and ask on #cockroachdb.
• Try find someone from here if you know they worked closely on the area and CC them.

_{🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf.}

[rafiss]

Let's add a test for this in pkg/sql/pgwire/testdata/pgtest - let me know if you need help with the syntax for these tests.

[fqazi]

@giangpham712 I see the correct behaviour if the start-up message has a bad database name:

Wraps: (2) waiting for *pgproto3.ReadyForQuery, got &pgproto3.ErrorResponse{Severity:"ERROR", SeverityUnlocalized:"ERROR", Code:"3D000", Message:"database \"fake\" does not exist", Detail:"", Hint:"", Position:0, InternalPosition:0, InternalQuery:"", Where:"", SchemaName:"", TableName:"", ColumnName:"", DataTypeName:"", ConstraintName:"", File:"errors.go", Line:148, Routine:"NewUndefinedDatabaseError", UnknownFields:map[uint8]string(nil)}

Are you relying on the implicit database name behaviour from: https://www.postgresql.org/docs/current/protocol-message-formats.html (see Startup Message)

[fqazi]

@giangpham712 Can you share the connection string for when this happens? Trying to figure out where things are going off the rails

[giangpham712]

@fqazi It could be something like this

Host=localhost;Username=crdb_tests;Port=26257;Include Error Detail=True;Timeout=300;Command Timeout=300;Options="-c null_ordered_last=true";Database=BatchingTest;Pooling=False;Multiplexing=False

[rafiss]

@fqazi maybe this related to mixed-case names specifically?

[fqazi]

No, case sensitivity also works fine if I try this in the pg_wire tests for CRDB. Let me try using Npgsql and seeing if that exhibits this problem

[fqazi]

@giangpham712 I tried the following sequence and still see the correct error in .NET (i.e. invalid database names error out correctly):

var connString = "Host=localhost;Username=root;Port=26257;Database=Defaultdb";
await using var conn = new NpgsqlConnection(connString);
await conn.OpenAsync();