Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cdc: add checkpoint progress metrics per changefeed #132281

Closed
rharding6373 opened this issue Oct 10, 2024 · 2 comments · Fixed by #137534
Closed

cdc: add checkpoint progress metrics per changefeed #132281

rharding6373 opened this issue Oct 10, 2024 · 2 comments · Fixed by #137534
Assignees
Labels
A-cdc Change Data Capture branch-release-23.2 Used to mark GA and release blockers, technical advisories, and bugs for 23.2 branch-release-24.1 Used to mark GA and release blockers, technical advisories, and bugs for 24.1 branch-release-24.2 Used to mark GA and release blockers, technical advisories, and bugs for 24.2 branch-release-24.3 Used to mark GA and release blockers, technical advisories, and bugs for 24.3 C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception) E-quick-win Likely to be a quick win for someone experienced. T-cdc

Comments

@rharding6373
Copy link
Collaborator

rharding6373 commented Oct 10, 2024

The changefeed.max_behind_nanos metric currently only reflects the lag of the furthest behind changefeed. However, there are times when it's useful to differentiate changefeed's progress. For example, if a cluster has multiple lagging changefeeds or a customer wants to check if a specific changefeed is lagging via a scoped metric label. We should make a scoped version of this metric.

Jira issue: CRDB-42917

Epic CRDB-42868

@rharding6373 rharding6373 added C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception) A-cdc Change Data Capture T-cdc E-quick-win Likely to be a quick win for someone experienced. labels Oct 10, 2024
Copy link

blathers-crl bot commented Oct 10, 2024

cc @cockroachdb/cdc

aerfrei added a commit to aerfrei/cockroach that referenced this issue Dec 17, 2024
Currently, changefeed.max_behind_nanos is a measurement of the
lag of the furthest behind changefeed. We'd like to be able to
support scoping/grouping changefeeds. This applies scoping to
that metric similar to the scoping on changefeed.aggregator_progress.

Epic: none
Fixes: cockroachdb#132281

Release note (ops change): the changefeed.max_behind_nanos metric
now supports scoping with metric labels.
aerfrei added a commit to aerfrei/cockroach that referenced this issue Dec 17, 2024
Currently, changefeed.max_behind_nanos is a measurement of the
lag of the furthest behind changefeed. We'd like to be able to
support scoping/grouping changefeeds. This applies scoping to
that metric similar to the scoping on changefeed.aggregator_progress.

Epic: none
Fixes: cockroachdb#132281

Release note (ops change): the changefeed.max_behind_nanos metric
now supports scoping with metric labels.
aerfrei added a commit to aerfrei/cockroach that referenced this issue Dec 17, 2024
Currently, changefeed.max_behind_nanos is a measurement of the
lag of the furthest behind changefeed. We'd like to be able to
support scoping/grouping changefeeds. This applies scoping to
that metric similar to the scoping on changefeed.aggregator_progress.

Epic: none
Fixes: cockroachdb#132281

Release note (ops change): the changefeed.max_behind_nanos metric
now supports scoping with metric labels.
aerfrei added a commit to aerfrei/cockroach that referenced this issue Dec 17, 2024
Currently, changefeed.max_behind_nanos is a measurement of the
lag of the furthest behind changefeed. We'd like to be able to
support scoping/grouping changefeeds. This applies scoping to
that metric similar to the scoping on changefeed.aggregator_progress.

Epic: none
Fixes: cockroachdb#132281

Release note (ops change): the changefeed.max_behind_nanos metric
now supports scoping with metric labels.
aerfrei added a commit to aerfrei/cockroach that referenced this issue Dec 17, 2024
Currently, changefeed.max_behind_nanos is a measurement of the
lag of the furthest behind changefeed. We'd like to be able to
support scoping/grouping changefeeds. This applies scoping to
that metric similar to the scoping on changefeed.aggregator_progress.

Epic: none
Fixes: cockroachdb#132281

Release note (ops change): the changefeed.max_behind_nanos metric
now supports scoping with metric labels.
aerfrei added a commit to aerfrei/cockroach that referenced this issue Dec 17, 2024
Currently, changefeed.max_behind_nanos is a measurement of the
lag of the furthest behind changefeed. We'd like to be able to
support scoping/grouping changefeeds. This applies scoping to
that metric similar to the scoping on changefeed.aggregator_progress.

Epic: none
Fixes: cockroachdb#132281

Release note (ops change): the changefeed.max_behind_nanos metric
now supports scoping with metric labels.
aerfrei added a commit to aerfrei/cockroach that referenced this issue Dec 17, 2024
Currently, changefeed.max_behind_nanos is a measurement of the
lag of the furthest behind changefeed. We'd like to be able to
support scoping/grouping changefeeds. This applies scoping to
that metric similar to the scoping on changefeed.aggregator_progress.

Epic: none
Fixes: cockroachdb#132281

Release note (ops change): the changefeed.max_behind_nanos metric
now supports scoping with metric labels.
aerfrei added a commit to aerfrei/cockroach that referenced this issue Dec 17, 2024
Currently, changefeed.max_behind_nanos is a measurement of the
lag of the furthest behind changefeed. We'd like to be able to
support scoping/grouping changefeeds. This applies scoping to
that metric similar to the scoping on changefeed.aggregator_progress.

Epic: none
Fixes: cockroachdb#132281

Release note (ops change): the changefeed.max_behind_nanos metric
now supports scoping with metric labels.
aerfrei added a commit to aerfrei/cockroach that referenced this issue Dec 17, 2024
Currently, changefeed.max_behind_nanos is a measurement of the
lag of the furthest behind changefeed. We'd like to be able to
support scoping/grouping changefeeds. This applies scoping to
that metric similar to the scoping on changefeed.aggregator_progress.

Epic: none
Fixes: cockroachdb#132281

Release note (ops change): the changefeed.max_behind_nanos metric
now supports scoping with metric labels.
aerfrei added a commit to aerfrei/cockroach that referenced this issue Dec 18, 2024
Currently, changefeed.max_behind_nanos is a measurement of the
lag of the furthest behind changefeed. We'd like to be able to
support scoping/grouping changefeeds. This applies scoping to
that metric similar to the scoping on changefeed.aggregator_progress.

Fixes: cockroachdb#132281

Release note (ops change): the changefeed.max_behind_nanos metric
now supports scoping with metric labels.
aerfrei added a commit to aerfrei/cockroach that referenced this issue Dec 18, 2024
Currently, changefeed.max_behind_nanos is a measurement of the
lag of the furthest behind changefeed. We'd like to be able to
support scoping/grouping changefeeds. This applies scoping to
that metric similar to the scoping on changefeed.aggregator_progress.

Fixes: cockroachdb#132281

Release note (ops change): the changefeed.max_behind_nanos metric
now supports scoping with metric labels.
aerfrei added a commit to aerfrei/cockroach that referenced this issue Dec 19, 2024
Currently, changefeed.max_behind_nanos is a measurement of the
lag of the furthest behind changefeed. We'd like to be able to
support scoping/grouping changefeeds. This applies scoping to
that metric similar to the scoping on changefeed.aggregator_progress.

Fixes: cockroachdb#132281

Release note (ops change): the changefeed.max_behind_nanos metric
now supports scoping with metric labels.
craig bot pushed a commit that referenced this issue Dec 19, 2024
137534: changefeedccl: add scoping support for max_behind_nanos r=andyyang890,asg0451 a=aerfrei

Currently, changefeed.max_behind_nanos is a measurement of the
lag of the furthest behind changefeed. We'd like to be able to
support scoping/grouping changefeeds. This applies scoping to
that metric similar to the scoping on changefeed.aggregator_progress.

Epic: none
Fixes: #132281

Release note (ops change): the changefeed.max_behind_nanos metric
now supports scoping with metric labels.

Co-authored-by: Aerin Freilich <[email protected]>
@craig craig bot closed this as completed in 0a3420e Dec 19, 2024
Copy link

blathers-crl bot commented Jan 16, 2025

Based on the specified backports for linked PR #137534, I applied the following new label(s) to this issue: branch-release-23.2, branch-release-24.1, branch-release-24.2, branch-release-24.3. Please adjust the labels as needed to match the branches actually affected by this issue, including adding any known older branches.

🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf.

@blathers-crl blathers-crl bot added branch-release-24.1 Used to mark GA and release blockers, technical advisories, and bugs for 24.1 branch-release-23.2 Used to mark GA and release blockers, technical advisories, and bugs for 23.2 branch-release-24.2 Used to mark GA and release blockers, technical advisories, and bugs for 24.2 branch-release-24.3 Used to mark GA and release blockers, technical advisories, and bugs for 24.3 labels Jan 16, 2025
blathers-crl bot pushed a commit that referenced this issue Jan 16, 2025
Currently, changefeed.max_behind_nanos is a measurement of the
lag of the furthest behind changefeed. We'd like to be able to
support scoping/grouping changefeeds. This applies scoping to
that metric similar to the scoping on changefeed.aggregator_progress.

Fixes: #132281

Release note (ops change): the changefeed.max_behind_nanos metric
now supports scoping with metric labels.
blathers-crl bot pushed a commit that referenced this issue Jan 16, 2025
Currently, changefeed.max_behind_nanos is a measurement of the
lag of the furthest behind changefeed. We'd like to be able to
support scoping/grouping changefeeds. This applies scoping to
that metric similar to the scoping on changefeed.aggregator_progress.

Fixes: #132281

Release note (ops change): the changefeed.max_behind_nanos metric
now supports scoping with metric labels.
aerfrei added a commit to aerfrei/cockroach that referenced this issue Jan 16, 2025
Currently, changefeed.max_behind_nanos is a measurement of the
lag of the furthest behind changefeed. We'd like to be able to
support scoping/grouping changefeeds. This applies scoping to
that metric similar to the scoping on changefeed.aggregator_progress.

Fixes: cockroachdb#132281

Release note (ops change): the changefeed.max_behind_nanos metric
now supports scoping with metric labels.
aerfrei added a commit to aerfrei/cockroach that referenced this issue Jan 17, 2025
Currently, changefeed.max_behind_nanos is a measurement of the
lag of the furthest behind changefeed. We'd like to be able to
support scoping/grouping changefeeds. This applies scoping to
that metric similar to the scoping on changefeed.aggregator_progress.

Fixes: cockroachdb#132281

Release note (ops change): the changefeed.max_behind_nanos metric
now supports scoping with metric labels.
aerfrei added a commit to aerfrei/cockroach that referenced this issue Jan 17, 2025
Currently, changefeed.max_behind_nanos is a measurement of the
lag of the furthest behind changefeed. We'd like to be able to
support scoping/grouping changefeeds. This applies scoping to
that metric similar to the scoping on changefeed.aggregator_progress.

Fixes: cockroachdb#132281

Release note (ops change): the changefeed.max_behind_nanos metric
now supports scoping with metric labels.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-cdc Change Data Capture branch-release-23.2 Used to mark GA and release blockers, technical advisories, and bugs for 23.2 branch-release-24.1 Used to mark GA and release blockers, technical advisories, and bugs for 24.1 branch-release-24.2 Used to mark GA and release blockers, technical advisories, and bugs for 24.2 branch-release-24.3 Used to mark GA and release blockers, technical advisories, and bugs for 24.3 C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception) E-quick-win Likely to be a quick win for someone experienced. T-cdc
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants