Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sql/tests: TestRandomSyntaxGeneration failed [building declarative schema change targets for DROP SCHEMA: unhandled kind: 0] #134752

Closed
cockroach-teamcity opened this issue Nov 9, 2024 · 2 comments · Fixed by #135149
Closed

sql/tests: TestRandomSyntaxGeneration failed [building declarative schema change targets for DROP SCHEMA: unhandled kind: 0] #134752

cockroach-teamcity opened this issue Nov 9, 2024 · 2 comments · Fixed by #135149
Assignees
@rafiss
Labels
branch-release-23.2 Used to mark GA and release blockers, technical advisories, and bugs for 23.2 branch-release-24.1 Used to mark GA and release blockers, technical advisories, and bugs for 24.1 branch-release-24.2 Used to mark GA and release blockers, technical advisories, and bugs for 24.2 branch-release-24.3 Used to mark GA and release blockers, technical advisories, and bugs for 24.3 C-test-failure Broken test (automatically or manually discovered). O-robot Originated from a bot. P-2 Issues/test failures with a fix SLA of 3 months T-sql-foundations SQL Foundations Team (formerly SQL Schema + SQL Sessions)

Comments

@cockroach-teamcity
Copy link
Member

cockroach-teamcity commented Nov 9, 2024 •
edited by cockroach-jira-scripts
Loading

sql/tests.TestRandomSyntaxGeneration failed with artifacts on release-24.2 @ 5764366875adca70c3a3ff3d4d13aaf599bc53a7:

Random syntax error:

    rsg_test.go:962: Crash detected: server panic: pq: internal error: building declarative schema change targets for DROP SCHEMA: unhandled kind: 0

Query:

        DROP SCHEMA IF EXISTS REPLACE , IMMUTABLE , ident . PUBLIC RESTRICT;
Help

See also: How To Investigate a Go Test Failure (internal)

Same failure on other branches

/cc @cockroachdb/sql-foundations

This test on roachdash | Improve this report!

Jira issue: CRDB-44213
@cockroach-teamcity cockroach-teamcity added branch-release-24.2 Used to mark GA and release blockers, technical advisories, and bugs for 24.2 C-test-failure Broken test (automatically or manually discovered). O-robot Originated from a bot. release-blocker Indicates a release-blocker. Use with branch-release-2x.x label to denote which branch is blocked. T-sql-foundations SQL Foundations Team (formerly SQL Schema + SQL Sessions) labels Nov 9, 2024
@rafiss rafiss removed the release-blocker Indicates a release-blocker. Use with branch-release-2x.x label to denote which branch is blocked. label Nov 9, 2024
@rafiss rafiss changed the title sql/tests: TestRandomSyntaxGeneration failed sql/tests: TestRandomSyntaxGeneration failed [building declarative schema change targets for DROP SCHEMA: unhandled kind: 0] Nov 9, 2024
@rafiss rafiss self-assigned this Nov 9, 2024
@exalate-issue-sync exalate-issue-sync bot added the P-2 Issues/test failures with a fix SLA of 3 months label Nov 9, 2024
@rafiss rafiss mentioned this issue Nov 9, 2024
Merged
@cockroach-teamcity cockroach-teamcity mentioned this issue Nov 11, 2024
Closed
@cockroach-teamcity
Copy link
Member Author

sql/tests.TestRandomSyntaxGeneration failed with artifacts on release-24.2 @ 5764366875adca70c3a3ff3d4d13aaf599bc53a7:

Random syntax error:

    rsg_test.go:962: Crash detected: server panic: pq: internal error: building declarative schema change targets for DROP SCHEMA: unhandled kind: 0

Query:

        DROP SCHEMA PUBLIC RESTRICT;
Help

See also: How To Investigate a Go Test Failure (internal)

Same failure on other branches

This test on roachdash | Improve this report!

craig bot pushed a commit that referenced this issue Nov 11, 2024
@angles-n-daemons @jbowens @rafiss
Merge #133840 #134748 #134770
c62b41d 
133840: apiutil, roachpb: create utilities to map descriptors to ranges r=angles-n-daemons a=angles-n-daemons

apiutil, roachpb: create utilities to map descriptors to ranges

Previously each range correlated to a single table, or even a single
index in a database, so all that was required to identify which tables,
indexes were in the range were to look at the start key of the range and
map it accordingly.

With range coalescing however, it's possible for one, or many tables,
indexes and the like to reside within the same range. To properly
identify the contents of a range, this PR adds the following utilities:

 1. A utility function which turns a range into a span, and clamps it
		to its tenant's table space.
 2. A utility function which takes the above spans and uses the catalog
		and new descriptor by span utility to turn those spans into a set of
		table descriptors ordered by id.
 3. A utility function which transforms those table descriptors into a
		set of (database, table, index) names which deduplicate and identify
		each index uniquely.
 4. A utility function, which merges the ranges and indexes into a map
		keyed by RangeID whose values are the above index names.
 5. A primary entrypoint for consumers from which a set of ranges can be
		passed in and a mapping from those ranges to indexes can be
		returned.

A variety of caveats come with this approach. It attempts to scan the
desrciptors all at once, but it still will scan a sizable portion of the
descriptors table if the request is large enough. This makes no attempt
to describe system information which does not have a descriptor. It will
describe system tables which appear in the descriptors table, but it
will not try to explain "tables" which do not have descriptors (example
tsdb), or any other information stored in the keyspace without a
descriptor (PseudoTableIDs, GossipKeys for example).

Throughout this work, many existing utilities were duplicated, and then
un-duplicated (`keys.TableDataMin`, `roachpb.Span.Overlap`, etc). If you
see anything that seems to already exist, feel free to point it out
accordingly.

Epic: CRDB-43151
Fixes: #130997

Release note: None

134748: storage: propagate KeySchemas to debug tools r=RaduBerinde a=jbowens

Ensure the `cockroach debug pebble ...` debug CLI tools can understand sstables with columnar blocks by propagating the CockroachDB KeySchema to the tool.

Epic: none
Release note: none

134770: sql/tests: include error with full stack trace in RSG tests r=rafiss a=rafiss

informs #133913
informs #134280
informs #133510
informs #134752
Release note: None

Co-authored-by: Brian Dillmann <[email protected]>
Co-authored-by: Jackson Owens <[email protected]>
Co-authored-by: Rafi Shamim <[email protected]>
This was referenced Nov 11, 2024
Merged
Merged
Merged
Merged
@cockroach-teamcity cockroach-teamcity mentioned this issue Nov 14, 2024
Closed
@rafiss rafiss mentioned this issue Nov 14, 2024
Merged
@craig craig bot closed this as completed in #135149 Nov 14, 2024
@craig craig bot closed this as completed in 724c140 Nov 14, 2024
@blathers-crl blathers[crl]
Copy link

blathers-crl bot commented Nov 14, 2024

Based on the specified backports for linked PR #135149, I applied the following new label(s) to this issue: branch-release-23.2, branch-release-24.1, branch-release-24.3. Please adjust the labels as needed to match the branches actually affected by this issue, including adding any known older branches.

🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf.

@blathers-crl blathers-crl bot added branch-release-24.1 Used to mark GA and release blockers, technical advisories, and bugs for 24.1 branch-release-23.2 Used to mark GA and release blockers, technical advisories, and bugs for 23.2 branch-release-24.3 Used to mark GA and release blockers, technical advisories, and bugs for 24.3 labels Nov 14, 2024
This was referenced Nov 14, 2024
Merged
Merged
@rafiss rafiss mentioned this issue Nov 14, 2024
Merged
@rafiss rafiss mentioned this issue Nov 14, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rafiss rafiss

Labels
branch-release-23.2 Used to mark GA and release blockers, technical advisories, and bugs for 23.2 branch-release-24.1 Used to mark GA and release blockers, technical advisories, and bugs for 24.1 branch-release-24.2 Used to mark GA and release blockers, technical advisories, and bugs for 24.2 branch-release-24.3 Used to mark GA and release blockers, technical advisories, and bugs for 24.3 C-test-failure Broken test (automatically or manually discovered). O-robot Originated from a bot. P-2 Issues/test failures with a fix SLA of 3 months T-sql-foundations SQL Foundations Team (formerly SQL Schema + SQL Sessions)
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

scbuild: fix unhandled case during DROP SCHEMA rafiss/cockroach
2 participants
@rafiss @cockroach-teamcity