-
Notifications
You must be signed in to change notification settings - Fork 3.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ui: migrate off of protobuf.js #27335
Comments
So what would we use to generate TS typings from protos? |
https://github.com/improbable-eng/ts-protoc-gen looks promising.
…On Tue, Jul 10, 2018 at 11:03 AM, Pete Vilter ***@***.***> wrote:
So what would we use to generate TS typings from protos?
—
You are receiving this because you were assigned.
Reply to this email directly, view it on GitHub
<#27335 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AA15IKFlewLCBw2EePPbsTizsgq8ITEzks5uFMImgaJpZM4VJk_p>
.
|
Could wasm be a solution for cockroach? moving the dashboard from JS to Go would make everything easier in my opinion |
Hi @Fale, thanks for the suggestion. Unfortunately the Go/Wasm ecosystem is still quite immature, and we have quite a bit of TypeScript code that would need to be rewritten. I'm afraid it's unlikely to be a solution we'll pursue. |
Looks like it still requires a proxy.
…On Wed, Oct 24, 2018, 17:30 Andrew Couch ***@***.***> wrote:
Related: https://www.cncf.io/blog/2018/10/24/grpc-web-is-going-ga/
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#27335 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ABdsPFFbnGAXwrbrpor7xvAM-UuA2wA0ks5uoNv0gaJpZM4VJk_p>
.
|
We have marked this issue as stale because it has been inactive for |
The library we currently use to generate JS code from protobuf definitions is dcodeIO/protobuf.js. Unfortunately, this library has given us numerous problems in the past. Many of these issues arise from a variety of uncommon and problematic design decisions. This, plus recent lack of activity in the repo, raise the question of the wisdom of using this libray long term. It's starting to look like we should cut our losses and investigate alternatives.
One related issue is #20109, the suggestion to stop sending protos across the wire, but instead use JSON. Even in that case, though, we want to use a library to generate our TypeScript typings for the responses, so this issue is still relevant.
Assigning to @benesch per our meat-space conversation.
The text was updated successfully, but these errors were encountered: