Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sql: support correlated subquery in INSERT #31721

Closed
maddyblue opened this issue Oct 23, 2018 · 2 comments · Fixed by #32729
Closed

sql: support correlated subquery in INSERT #31721

maddyblue opened this issue Oct 23, 2018 · 2 comments · Fixed by #32729
Labels
A-sql-optimizer SQL logical planning and optimizations. A-tools-hibernate Issues that pertain to Hibernate integration. C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception)

Comments

@maddyblue
Copy link
Contributor

From hibernate org.hibernate.test.hql.InsertWithSubSelectTest

   insert 
    into
        C
        ( id ) select
            insertwith0_.id as col_0_0_ 
        from
            A insertwith0_ 
        where
            exists (
                select
                    1 
                from
                    B insertwith1_ 
                where
                    insertwith1_.id=insertwith0_.id
            )

See #31670
@maddyblue maddyblue added C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception) A-tools-hibernate Issues that pertain to Hibernate integration. labels Oct 23, 2018
@knz knz added the A-sql-optimizer SQL logical planning and optimizations. label Oct 23, 2018
@knz knz mentioned this issue Oct 23, 2018
Closed
@BramGruneir
Copy link
Member

This just is now passing in 2.2.

I think due to #32423.

@BramGruneir BramGruneir mentioned this issue Nov 29, 2018
Merged
@maddyblue
Copy link
Contributor Author

Can we close this then?

BramGruneir added a commit to BramGruneir/cockroach that referenced this issue Dec 3, 2018
@BramGruneir
roachtest: Update hibernate blacklist 2.2
1cd5a47 
Due to cockroachdb#32423, cockroachdb#31721 has been fixed.

Also cleaned up the test output a little bit.

Closes cockroachdb#31721.
Fixes cockroachdb#32714.

Release note: None
craig bot pushed a commit that referenced this issue Dec 3, 2018
@BramGruneir
Merge #32729
c91b628 
32729: roachtest: Update hibernate blacklist 2.2 r=BramGruneir a=BramGruneir

Due to #32423, #31721 has been fixed.

Also cleaned up the test output a little bit.

Closes #31721.
Fixes #32714.

Release note: None

Co-authored-by: Bram Gruneir <[email protected]>
@craig craig bot closed this as completed in #32729 Dec 3, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-sql-optimizer SQL logical planning and optimizations. A-tools-hibernate Issues that pertain to Hibernate integration. C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception)
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

roachtest: Update hibernate blacklist 2.2 BramGruneir/cockroach
3 participants
@maddyblue @knz @BramGruneir