Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

roachtest: hibernate failed #32532

Closed
cockroach-teamcity opened this issue Nov 21, 2018 · 7 comments
Closed

roachtest: hibernate failed #32532

cockroach-teamcity opened this issue Nov 21, 2018 · 7 comments
Assignees
Labels
C-test-failure Broken test (automatically or manually discovered). O-robot Originated from a bot.
Milestone

Comments

@cockroach-teamcity
Copy link
Member

SHA: https://github.com/cockroachdb/cockroach/commits/cfd53f62f038a06e34570f11ec02bc74dabd2aab

Parameters:

To repro, try:

# Don't forget to check out a clean suitable branch and experiment with the
# stress invocation until the desired results present themselves. For example,
# using stress instead of stressrace and passing the '-p' stressflag which
# controls concurrency.
./scripts/gceworker.sh start && ./scripts/gceworker.sh mosh
cd ~/go/src/github.com/cockroachdb/cockroach && \
make stressrace TESTS=hibernate PKG=roachtest TESTTIMEOUT=5m STRESSFLAGS='-maxtime 20m -timeout 10m' 2>&1 | tee /tmp/stress.log

Failed test: https://teamcity.cockroachdb.com/viewLog.html?buildId=1021046&tab=buildLog

The test failed on master:
	test.go:650,hibernate.go:284,hibernate.go:299: 
		4 tests failed unexpectedly
		2 tests passed unexpectedly
		0 tests were not run that were expected to fail
		See artifacts/hibernate/log/logs/report for more details

@cockroach-teamcity cockroach-teamcity added this to the 2.2 milestone Nov 21, 2018
@cockroach-teamcity cockroach-teamcity added C-test-failure Broken test (automatically or manually discovered). O-robot Originated from a bot. labels Nov 21, 2018
@BramGruneir
Copy link
Member

My best guess is that this is fallout from @lucy-zhang's latest change.

Lucy, can you investigate this?

@BramGruneir
Copy link
Member

take a look in the artifacts -> hibernate log for (unexpected).

@cockroach-teamcity
Copy link
Member Author

SHA: https://github.com/cockroachdb/cockroach/commits/96f03c95d5078ebad7167c5cdb145e365978a008

Parameters:

To repro, try:

# Don't forget to check out a clean suitable branch and experiment with the
# stress invocation until the desired results present themselves. For example,
# using stress instead of stressrace and passing the '-p' stressflag which
# controls concurrency.
./scripts/gceworker.sh start && ./scripts/gceworker.sh mosh
cd ~/go/src/github.com/cockroachdb/cockroach && \
make stressrace TESTS=hibernate PKG=roachtest TESTTIMEOUT=5m STRESSFLAGS='-maxtime 20m -timeout 10m' 2>&1 | tee /tmp/stress.log

Failed test: https://teamcity.cockroachdb.com/viewLog.html?buildId=1022695&tab=buildLog

The test failed on master:
	test.go:650,hibernate.go:284,hibernate.go:299: 
		4 tests failed unexpectedly
		2 tests passed unexpectedly
		0 tests were not run that were expected to fail
		See artifacts/hibernate/log/logs/report for more details

@cockroach-teamcity
Copy link
Member Author

SHA: https://github.com/cockroachdb/cockroach/commits/93632938e9ea7d86a56ec8423f2eff66c30965d5

Parameters:

To repro, try:

# Don't forget to check out a clean suitable branch and experiment with the
# stress invocation until the desired results present themselves. For example,
# using stress instead of stressrace and passing the '-p' stressflag which
# controls concurrency.
./scripts/gceworker.sh start && ./scripts/gceworker.sh mosh
cd ~/go/src/github.com/cockroachdb/cockroach && \
make stressrace TESTS=hibernate PKG=roachtest TESTTIMEOUT=5m STRESSFLAGS='-maxtime 20m -timeout 10m' 2>&1 | tee /tmp/stress.log

Failed test: https://teamcity.cockroachdb.com/viewLog.html?buildId=1023971&tab=buildLog

The test failed on master:
	test.go:650,hibernate.go:284,hibernate.go:299: 
		4 tests failed unexpectedly
		2 tests passed unexpectedly
		0 tests were not run that were expected to fail
		See artifacts/hibernate/log/logs/report for more details

@cockroach-teamcity
Copy link
Member Author

SHA: https://github.com/cockroachdb/cockroach/commits/1bcb46e7bf7c03e95128f44de8f24dbdc6a231f0

Parameters:

To repro, try:

# Don't forget to check out a clean suitable branch and experiment with the
# stress invocation until the desired results present themselves. For example,
# using stress instead of stressrace and passing the '-p' stressflag which
# controls concurrency.
./scripts/gceworker.sh start && ./scripts/gceworker.sh mosh
cd ~/go/src/github.com/cockroachdb/cockroach && \
make stressrace TESTS=hibernate PKG=roachtest TESTTIMEOUT=5m STRESSFLAGS='-maxtime 20m -timeout 10m' 2>&1 | tee /tmp/stress.log

Failed test: https://teamcity.cockroachdb.com/viewLog.html?buildId=1024654&tab=buildLog

The test failed on master:
	test.go:650,hibernate.go:284,hibernate.go:299: 
		4 tests failed unexpectedly
		2 tests passed unexpectedly
		0 tests were not run that were expected to fail
		See artifacts/hibernate/log/logs/report for more details

@BramGruneir
Copy link
Member

2 new passing tests:

  • org.hibernate.test.legacy.FooBarTest.testOnCascadeDelete
  • org.hibernate.test.ondelete.OnDeleteTest.testJoinedSubclass

Of the 4 failing tests:

  • org.hibernate.test.legacy.MasterDetailTest.testExample - fails due to an FK violation
  • org.hibernate.test.legacy.MasterDetailTest.testSelfManyToOne - fails due to an FK violation
  • org.hibernate.test.legacy.MultiTableTest.testMultiTableCollections - no results file in artifacts
  • org.hibernate.test.legacy.MultiTableTest.testMultiTableManyToOne - no results file in artifacts

I'll be re-running all of these to get more details. Interesting that we've got an unexpected FK violation.

@BramGruneir
Copy link
Member

Got the results files for all the newly failed tests:

Both are of the form: ERROR: foreign key violation: value [3] not found in leafsubclass@primary [id__] (txn=92ebcc1f-36c2-416b-87ca-12c0f73470a3)

BramGruneir added a commit to BramGruneir/cockroach that referenced this issue Nov 26, 2018
Thanks to the update to allow adding FK constraints on empty tables cockroachdb#32234, the
blacklist needs to be updated.  Sadly, 2 tests now pass, but 4 others now fail
due to cockroachdb#32610.

Fixes cockroachdb#32532.

Release note: None
craig bot pushed a commit that referenced this issue Nov 26, 2018
32611: roachtest: updated the hibernate blacklist for 2.2 r=BramGruneir a=BramGruneir

Thanks to the update to allow adding FK constraints on empty tables #32234, the
blacklist needs to be updated.  Sadly, 2 tests now pass, but 4 others now fail
due to #32610.

Fixes #32532.

Release note: None

Co-authored-by: Bram Gruneir <[email protected]>
@craig craig bot closed this as completed in #32611 Nov 26, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-test-failure Broken test (automatically or manually discovered). O-robot Originated from a bot.
Projects
None yet
Development

No branches or pull requests

3 participants