Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ui: Add line break to localities on Network latency tooltip + style updates #45228

Closed
4 tasks
Annebirzin opened this issue Feb 19, 2020 · 0 comments · Fixed by #45638
Closed
4 tasks

ui: Add line break to localities on Network latency tooltip + style updates #45228

Annebirzin opened this issue Feb 19, 2020 · 0 comments · Fixed by #45638
Assignees
@vladlos
Labels
A-webui-general Issues on the DB Console that span multiple areas or don't have another clear category.

Comments

@Annebirzin
Copy link

Annebirzin commented Feb 19, 2020 •
edited
Loading

Update latency tool tips. Designs here

  • tooltip width should be ~384px wide
  • Break locality info onto separate lines
  • Update all text in tooltip to Source Sans Pro (related to ui: update colors and fonts across admin ui #45471)
  • Update time stamp colors (ie. 27.03ms roundtrip):
    • Disconnected= #FFCD02
    • Mean = #E7ECF3
    • < -1 and < -2 = #76DE49
    • > +1 and > +2 = #74BDFD

Network-Latency-06
@Annebirzin Annebirzin added the A-webui-general Issues on the DB Console that span multiple areas or don't have another clear category. label Feb 19, 2020
@Annebirzin Annebirzin changed the title ui: Network latency tooltip updates ui: Add line break to localities on Network latency tooltip Feb 26, 2020
@Annebirzin Annebirzin changed the title ui: Add line break to localities on Network latency tooltip ui: Add line break to localities on Network latency tooltip + style updates Feb 27, 2020
@vladlos vladlos self-assigned this Mar 3, 2020
@vladlos vladlos mentioned this issue Mar 3, 2020
Merged
craig bot pushed a commit that referenced this issue May 26, 2020
@vladlos
Merge #45638
e6c15ca 
45638: ui: Network latency tooltip r=dhartunian a=elkmaster

Updated tooltip styles.

Resolves: #45228

Release note (ui): none

Co-authored-by: Vlad Los <[email protected]>
Co-authored-by: Vlad <[email protected]>
@craig craig bot closed this as completed in 99bb159 May 26, 2020
jbowens pushed a commit to jbowens/cockroach that referenced this issue Jun 1, 2020
@vladlos @jbowens
ui: Network latency tooltip
619c7c5 
Updated tooltip styles.

Resolves: cockroachdb#45228

Release note (ui): none
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@vladlos vladlos

Labels
A-webui-general Issues on the DB Console that span multiple areas or don't have another clear category.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

ui: Network latency tooltip vladlos/cockroach
2 participants
@vladlos @Annebirzin