-
Notifications
You must be signed in to change notification settings - Fork 3.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
sql: use virtual column for hash shared indexes #61564
Labels
C-enhancement
Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception)
T-sql-foundations
SQL Foundations Team (formerly SQL Schema + SQL Sessions)
Comments
RaduBerinde
added
the
C-bug
Code not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior.
label
Mar 5, 2021
RaduBerinde
added
C-enhancement
Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception)
and removed
C-bug
Code not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior.
labels
Mar 5, 2021
30 tasks
exalate-issue-sync
bot
added
T-sql-schema-deprecated
Use T-sql-foundations instead
and removed
T-sql-queries
SQL Queries Team
labels
Jun 29, 2021
chengxiong-ruan
added a commit
to chengxiong-ruan/cockroach
that referenced
this issue
Dec 14, 2021
fixes cockroachdb#61564 , also fixes cockroachdb#73622 as a bonus Previously we use `STORED` computed column for shard column of hash index. This pr makes it use virtual column instead. The major change is actually to allow virtual column in primary key by loosening some index validation with extrac checks. Release note (sql change): Virtual column is now allowed in primary key and shard column of hash-sharded index is now a virtual column.
craig bot
pushed a commit
that referenced
this issue
Dec 21, 2021
74138: sql: use virtual column for hash sharded index r=chengxiong-ruan a=chengxiong-ruan fixes #61564 This pr sets `Virtual=True` for shard column when creating a hash sharded index. The shard column won't be in any column family since it's virtual. Release note (sql change): Shard column of hash sharded index is now a virtual column instead of stored. 74165: changefeedccl: Reduce log spam when memory tight. r=miretskiy a=miretskiy Blocking buffer logs events every time a request is blocked for too long (5 seconds). However, when we acquire the resource, we also log how long that resource waited for. Because blocking allows concurrent ingestion of events, this resulted in substantial number of log messages generated in short burts when running under high concurrency settings. Reduce the number of these log messages by only logging periodically. Release Notes: None Co-authored-by: Chengxiong Ruan <[email protected]> Co-authored-by: Yevgeniy Miretskiy <[email protected]>
gustasva
pushed a commit
to gustasva/cockroach
that referenced
this issue
Jan 4, 2022
fixes cockroachdb#61564 This pr sets `Virtual=True` for shard column when creating a hash sharded index. The shard column won't be in any column family since it's virtual. Release note (sql change): Shard column of hash sharded index is now a virtual column instead of stored.
exalate-issue-sync
bot
removed
the
T-sql-schema-deprecated
Use T-sql-foundations instead
label
May 10, 2023
exalate-issue-sync
bot
added
the
T-sql-foundations
SQL Foundations Team (formerly SQL Schema + SQL Sessions)
label
May 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
C-enhancement
Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception)
T-sql-foundations
SQL Foundations Team (formerly SQL Schema + SQL Sessions)
This issue tracks changing the experimental hash-sharded indexes to use a virtual column instead of a stored column.
Epic CRDB-7363
The text was updated successfully, but these errors were encountered: