Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

release-23.1.0: catalog: utilize scans for a large number of descriptors #101968

Merged
merged 1 commit into from
Apr 21, 2023

Conversation

blathers-crl[bot]
Copy link

@blathers-crl blathers-crl bot commented Apr 20, 2023

Backport 1/1 commits from #101937 on behalf of @fqazi.

/cc @cockroachdb/release


Previously, the catalog descriptor would fetch descriptors via point lookups using Get when scanning large batches of descriptors. This was further extended to also look up ZoneConfigs and comments in a similar way. Recently, we we started seeing regression on the Django test suite involving the pg_catalog tables, which tend to do read large number of descriptors, likely linked to extra overhead linked to both comments and zone configs in 23.1. To address this, this patch ill now start using scans for runs of descriptor IDs for batch scans which reduces the overall cost of fetching a large number of descriptors hiding this cost.

Fixes: #100871

Release note: None


Release justification: low risk and address a major regression on the Django test suite

Previously, the catalog descriptor would fetch descriptors
via point lookups using Get when scanning large batches
of descriptors. This was further extended to also look up
ZoneConfigs and comments in a similar way. Recently, we
we started seeing regression on the Django test suite involving the
pg_catalog tables, which tend to do read large number of
descriptors, likely linked to extra overhead linked
to both comments and zone configs in 23.1. To address this,
this patch ill now start using scans for runs of descriptor IDs for batch
scans which reduces the overall cost of fetching a large number
of descriptors hiding this cost.

Fixes: #100871

Release note: None
@blathers-crl blathers-crl bot requested a review from a team April 20, 2023 22:46
@blathers-crl blathers-crl bot force-pushed the blathers/backport-release-23.1.0-101937 branch 2 times, most recently from 73bfba8 to 834d814 Compare April 20, 2023 22:46
@blathers-crl blathers-crl bot added blathers-backport This is a backport that Blathers created automatically. O-robot Originated from a bot. labels Apr 20, 2023
@blathers-crl
Copy link
Author

blathers-crl bot commented Apr 20, 2023

Thanks for opening a backport.

Please check the backport criteria before merging:

  • Patches should only be created for serious issues or test-only changes.
  • Patches should not break backwards-compatibility.
  • Patches should change as little code as possible.
  • Patches should not change on-disk formats or node communication protocols.
  • Patches should not add new functionality.
  • Patches must not add, edit, or otherwise modify cluster versions; or add version gates.
If some of the basic criteria cannot be satisfied, ensure that the exceptional criteria are satisfied within.
  • There is a high priority need for the functionality that cannot wait until the next release and is difficult to address in another way.
  • The new functionality is additive-only and only runs for clusters which have specifically “opted in” to it (e.g. by a cluster setting).
  • New code is protected by a conditional check that is trivial to verify and ensures that it only runs for opt-in clusters.
  • The PM and TL on the team that owns the changed code have signed off that the change obeys the above rules.

Add a brief release justification to the body of your PR to justify this backport.

Some other things to consider:

  • What did we do to ensure that a user that doesn’t know & care about this backport, has no idea that it happened?
  • Will this work in a cluster of mixed patch versions? Did we test that?
  • If a user upgrades a patch version, uses this feature, and then downgrades, what happens?

@cockroach-teamcity
Copy link
Member

This change is Reviewable

@rimadeodhar rimadeodhar self-requested a review April 21, 2023 16:53
@fqazi
Copy link
Collaborator

fqazi commented Apr 21, 2023

@rimadeodhar @chengxiong-ruan TFTR

@fqazi fqazi merged commit e4ad376 into release-23.1.0 Apr 21, 2023
@fqazi fqazi deleted the blathers/backport-release-23.1.0-101937 branch April 21, 2023 16:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
blathers-backport This is a backport that Blathers created automatically. O-robot Originated from a bot.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants